public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: elfutils-devel@sourceware.org
Cc: fche@redhat.com, amerey@redhat.com
Subject: Some debuginfod fixlets
Date: Sat, 16 Nov 2019 16:42:00 -0000	[thread overview]
Message-ID: <5e3dcf2f4196177e68cf4c09714af5a4d29c3640.camel@klomp.org> (raw)

Hi,

While testing Frank's new spec/rpms for the run-debuginfod-find.sh
testcase I found a couple of issues that I pushed to the debuginfod-
submit branch.

  Add tests/debuginfod-rpms to EXTRA_DISTS.
  Fix two small memory leaks in debuginfod-find and testcase.
  Increase timeout for run-debuginfod-find.sh
  run-debuginfod-find.sh: Use abs_srcdir when copying debuginfod-rpms
  debuginfod: Accept empty comp_dir when cuname is absolute.

With these fixes everything passes make distcheck locally.

The only interesting one is debuginfod: Accept empty comp_dir when
cuname is absolute. This can happen with gcc 4.8.5. In that case we
have a CU DIE with an absolute DW_AT_name, but no DW_AT_comp_dir. And
the files in the debug_line table never reference the comp_dir (dir
entry zero). For example:

 [     b]  compile_unit         abbrev: 1
           producer             (strp) "GNU C 4.8.5 20150623 (Red Hat 4.8.5-39) -mtune=generic -march=x86-64 -g"
           language             (data1) C89 (1)
           name                 (strp) "/home/mark/build/elfutils-obj/prog.c"
           low_pc               (addr) 0x00000000004004ed
           high_pc              (data8) 11 (0x00000000004004f8)
           stmt_list            (sec_offset) 0

Directory table:
 /home/mark/build/elfutils-obj

File name table:
 Entry Dir   Time      Size      Name
 1     1     0         0         prog.c

Hopefully these changes are correct. If not, please let me know, and
apologies for pushing them on your branch.

Cheers,

Mark

             reply	other threads:[~2019-11-16 16:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-16 16:42 Mark Wielaard [this message]
2019-11-17 16:22 ` Mark Wielaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e3dcf2f4196177e68cf4c09714af5a4d29c3640.camel@klomp.org \
    --to=mark@klomp.org \
    --cc=amerey@redhat.com \
    --cc=elfutils-devel@sourceware.org \
    --cc=fche@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).