From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id 82B243851C27 for ; Wed, 10 Jun 2020 10:18:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 82B243851C27 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mark@klomp.org Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 8FECB300071B for ; Wed, 10 Jun 2020 12:18:05 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 88BC74708687; Wed, 10 Jun 2020 12:18:05 +0200 (CEST) Message-ID: <5f80b6d6f0f344132c27a23dc84773d0ac85f462.camel@klomp.org> Subject: Re: [PATCH] nm: Handle corrupt symbol name table. From: Mark Wielaard To: elfutils-devel@sourceware.org Date: Wed, 10 Jun 2020 12:18:05 +0200 In-Reply-To: <20200607145124.32214-1-mark@klomp.org> References: <20200607145124.32214-1-mark@klomp.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-8.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jun 2020 10:18:07 -0000 On Sun, 2020-06-07 at 16:51 +0200, Mark Wielaard wrote: > We try to sort symbol by name (when neither -n nor -p are given). > This could crash if the symbol name table was corrupt. Use elf_strptr > to get the symbol name and use the empty string in case a name > couldn't be found. Pushed to master.