From: Mark Wielaard <mark@klomp.org>
To: Jim Wilson <jimw@sifive.com>, elfutils-devel@sourceware.org
Subject: Re: [PATCH] RISC-V: Add untested 32-bit core file support.
Date: Sat, 12 Jan 2019 22:29:00 -0000 [thread overview]
Message-ID: <610f78bbaaa4558d69b6c20e244a0b8416f3c3a7.camel@klomp.org> (raw)
In-Reply-To: <20181227232702.16823-1-jimw@sifive.com>
On Thu, 2018-12-27 at 15:27 -0800, Jim Wilson wrote:
> This conflicts with the previoues two patches. Adds 32-bit support exactly the
> same way that the sparc backend handles 32- and 64-bit core file support. The
> 64-bit core file support was tested and still works same as before.
I don't really like adding code that cannot be tested. But it does look
the 32-bit port isn't far off, just waiting for the next linux/glibc
release to settle the time_t ABI. And the code does look correct.
Except for...
> static const Ebl_Register_Location prstatus_regs[] =
> {
> - { .offset = 8, .regno = 1, .count = 31, .bits = 64 } /* x1..x31 */
> + { .offset = BITS/8, .regno = 1, .count = 31, .bits = 64 } /* x1..x31 */
> };
Should that be .bits = BITS ?
Thanks,
Mark
next prev parent reply other threads:[~2019-01-12 22:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-27 23:27 Jim Wilson
2019-01-12 22:29 ` Mark Wielaard [this message]
2019-01-13 0:38 ` Jim Wilson
2019-01-13 10:12 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=610f78bbaaa4558d69b6c20e244a0b8416f3c3a7.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=jimw@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).