From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 757FC3858D39 for ; Tue, 9 Nov 2021 13:31:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 757FC3858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A6C001FDB7; Tue, 9 Nov 2021 13:31:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1636464705; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5mmOFIE/fKmu3zugNjNOIkgJmobAEbN8N38EO23HYGQ=; b=2zGZUhD/CY5EmK1D4ZpQL06T/61oFTe888VnkzIvCseJLGtsGdaltrS8IIzH18addsAW8s D4RcjOixmS/V8Z3TeoTEms9df4nr0r6WlO5G0soY0dBA2ZYhd52Xsze0J6y0ooGWQkFbT4 VD6cRX+LIlqkHXP20LNh2NcBwaVKXdM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1636464705; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5mmOFIE/fKmu3zugNjNOIkgJmobAEbN8N38EO23HYGQ=; b=MVvdfExZfmsSXOrHj5k28tNmj8gI1UmlX5+9aUw1ns2cDEUoMmP3g7l+utA5vz92q/PX8P cWqTAIjJ0tTewGAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8AA5913A23; Tue, 9 Nov 2021 13:31:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id fsDGIEF4imEYWAAAMHmgww (envelope-from ); Tue, 09 Nov 2021 13:31:45 +0000 Message-ID: <64e5109f-1515-c0d1-88e1-7cbc963a0e75@suse.cz> Date: Tue, 9 Nov 2021 14:31:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH v2] Improve building with LTO Content-Language: en-US To: Mark Wielaard , "Dmitry V. Levin" , elfutils-devel@sourceware.org References: <20210214235718.7654b5f1.alex.miller@gmx.de> <20210218033856.18053044.alex.miller@gmx.de> <20210828093143.GA720@altlinux.org> <20211104112320.GA732@altlinux.org> <20211108100228.GC27916@altlinux.org> <20211109085820.GA11255@altlinux.org> <9eba865f-af61-6452-161c-2dc081ebae69@suse.cz> <618afb58a9328bc9bbcc394fc17ef907ac6f188e.camel@klomp.org> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: <618afb58a9328bc9bbcc394fc17ef907ac6f188e.camel@klomp.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_ASCII_DIVIDERS, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Nov 2021 13:31:48 -0000 On 11/9/21 12:45, Mark Wielaard wrote: > Hi Martin, > > On Tue, 2021-11-09 at 10:04 +0100, Martin Liška wrote: >> On 11/9/21 09:58, Dmitry V. Levin wrote: >>> Yes, but those who build elfutils with -flto are likely using >>> -ffat-lto-objects if they build static libraries. >> >> Yes, I can confirm that we do that as openSUSE, we actually build >> with: >> >> -flto -flto-partition=none -Wno-error=stack-usage= -ffat-lto-objects > > As Dmitry pointed out you should now be able to drop both -flto- > partition=none an -Wno-error=stack-usage= (the linker will still warn, > but not error on the large stack-usage issues (we should probably still > fix them though). Correct, I'm not using: F="-O2 -g -Wall -flto=auto -ffat-lto-objects" && export CFLAGS="$F" && export CXXFLAGS="$F" && export LDFLAGS="$F" && ./configure > > What do the test results look like? Do they all PASS with -ffat-lto- > objects? > > Could you try the proposed patch for > https://sourceware.org/bugzilla/show_bug.cgi?id=27367 > https://sourceware.org/pipermail/elfutils-devel/2021q4/004314.html With the suggested patch (and BFD) all is green and shiny: ============================================================================ Testsuite summary for elfutils 0.185 ============================================================================ # TOTAL: 252 # PASS: 249 # SKIP: 3 # XFAIL: 0 # FAIL: 0 # XPASS: 0 # ERROR: 0 Cheers, Martin > > Thanks, > > Mark >