From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5879 invoked by alias); 7 Nov 2018 09:03:15 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 5853 invoked by uid 89); 7 Nov 2018 09:03:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=experts, Experts, ccache, deutschland X-Spam-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: mail.kdab.com Received: from mail.kdab.com (HELO mail.kdab.com) (176.9.126.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Nov 2018 09:03:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kdab.com; h= content-type:content-type:mime-version:references:in-reply-to :organization:message-id:date:date:subject:subject:from:from; s= dkim; t=1541581383; x=1542445384; bh=SfAXKulow/QLq3JBOyTrlJ7qOaJ wXcehLnRMOXlnq8o=; b=lZyb1YwyjSaSh7Hec46m4ae7KlvE/ia2fFkxJewO8jS wdInJmCSjjALHgb5RIngzXivEhEfdz5N2k6hAG68GgEX+5Amgfh75NA4cJJNldk8 7Wv+rpnzrdMH84SaIr2FRLJCL4XH8lS3DeW4UPVGUqS++3polSRpbS06DXmiP1do = X-Virus-Scanned: amavisd-new at kdab.com From: Milian Wolff To: elfutils-devel@sourceware.org Cc: Mark Wielaard Subject: Re: [PATCH] Also find CFI in sections of type SHT_X86_64_UNWIND Date: Wed, 07 Nov 2018 09:03:00 -0000 Message-ID: <6704910.BGFJc7X5JR@agathebauer> Organization: KDAB In-Reply-To: References: <20181029152126.32610-1-milian.wolff@kdab.com> <2537678.yolsnJm5dN@agathebauer> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2529565.WcsbrJ28ph"; micalg="sha256"; protocol="application/pkcs7-signature" X-SW-Source: 2018-q4/txt/msg00102.txt.bz2 --nextPart2529565.WcsbrJ28ph Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Content-length: 3051 On Dienstag, 6. November 2018 12:06:57 CET Mark Wielaard wrote: > Hi Milian, > > On Tue, 2018-11-06 at 00:12 +0100, Milian Wolff wrote: > > On Montag, 5. November 2018 00:04:32 CET Mark Wielaard wrote: > > > > Interestingly, when I try to reproduce this on my laptop (i.e. compile > > even > > the trivial C example), then I cannot reproduce this at all anymore - the > > .eh_frame sections show up as PROGBITS. My desktop at work still shows > > this > > behavior though (also see below). I can't quite explain this difference... > > It seems to only happen with a specific combination of gcc and the gold > linker, I could only generate the SHT_X86_64_UNWIND sections only on > fedora 29 with gcc 8.2.1 and gold version 2.31.1-13.fc29 (1.16). At least on my system, that doesn't seem to be enough. Both my desktop and my laptop are running on ArchLinux with the same versions of GCC and Gold, yet one shows this behavior while the other one isn't... What I noticed is that ccache seems to influence it for me, which makes this even stranger: ``` $ which gcc /usr/lib/ccache/bin/gcc $ gcc --version gcc (GCC) 8.2.1 20180831 Copyright (C) 2018 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. $ gcc test.c $ readelf -S a.out | grep eh_frame [14] .eh_frame_hdr PROGBITS 0000000000002004 00002004 [15] .eh_frame PROGBITS 0000000000002030 00002030 $ /usr/bin/gcc test.c $ /usr/bin/gcc --version gcc (GCC) 8.2.1 20180831 Copyright (C) 2018 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. $ /usr/bin/gcc test.c $ readelf -S a.out | grep eh_frame [14] .eh_frame X86_64_UNWIND 0000000000000670 00000670 [15] .eh_frame_hdr X86_64_UNWIND 0000000000000724 00000724 ``` Anyhow, that's unrelated to the patches at hand here. See below. > > > - It might be better to change the check to shdr->sh_type != SHT_NOBITS > > > > > > The idea is probably that we don't want to look at the data in case > > > this is a .debug file which has it removed. This might be better than > > > adding a check for X86_64_UNWIND since then we would also need to > > > check the arch. Does != SHT_NOBITS work for you? > > > > Yes, since SHT_NOBITS is not equal to SHT_X86_64_UNWIND :) > > OK, then lets change your patch to do that as attached. > > > > - What does eu-readelf -S show? > > > > > > I think we need a x86_64_section_type_name () ebl hook to show it > > > correctly. > > > > Yes, that looks like it: > > And the other attached patch should clean that up. Both patches work for me: Tested-by: Milian Wolff Thanks -- Milian Wolff | milian.wolff@kdab.com | Senior Software Engineer KDAB (Deutschland) GmbH, a KDAB Group company Tel: +49-30-521325470 KDAB - The Qt, C++ and OpenGL Experts --nextPart2529565.WcsbrJ28ph Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 Content-length: 5190 MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG 9w0BBwEAAKCCDEIwggXmMIIDzqADAgECAhBqm+E4O/8ra58B1dm4p1JWMA0G CSqGSIb3DQEBDAUAMIGFMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRl ciBNYW5jaGVzdGVyMRAwDgYDVQQHEwdTYWxmb3JkMRowGAYDVQQKExFDT01P RE8gQ0EgTGltaXRlZDErMCkGA1UEAxMiQ09NT0RPIFJTQSBDZXJ0aWZpY2F0 aW9uIEF1dGhvcml0eTAeFw0xMzAxMTAwMDAwMDBaFw0yODAxMDkyMzU5NTla MIGXMQswCQYDVQQGEwJHQjEbMBkGA1UECBMSR3JlYXRlciBNYW5jaGVzdGVy MRAwDgYDVQQHEwdTYWxmb3JkMRowGAYDVQQKExFDT01PRE8gQ0EgTGltaXRl ZDE9MDsGA1UEAxM0Q09NT0RPIFJTQSBDbGllbnQgQXV0aGVudGljYXRpb24g YW5kIFNlY3VyZSBFbWFpbCBDQTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCC AQoCggEBAL6znlesKHZ1QBbHOAOY08YYdiFQ8yV5C0y1oNF9Olg+nKcxLqf2 NHbZhGra0D00SOTq9bus3/mxgUsg/Wh/eXQ0pnp8tZ8XZWAnlyKMpjL+qUBy RjXCA6RQyDMqVaVUkbIr5SU0RDX/kSsKwer3H1pT/HUrBN0X8sKtPTdGX8XA Wt/VdMLBrZBlgvnkCos+KQWWCo63OTTqRvaq8aWccm+KOMjTcE6s2mj6Rkal weyDI7X+7U5lNo6jzC8RTXtVV4/Vwdax720YpMPJQaDaElmOupyTf1Qib+cp ukNJnQmwygjD8m046DQkLnpXNCAGjuJy1F5NATksUsbfJAr7FLUCAwEAAaOC ATwwggE4MB8GA1UdIwQYMBaAFLuvfgI9+qbxPISOre44mOzZMjLUMB0GA1Ud DgQWBBSCr2yM+MX+lmF86B89K3FIXsSLwDAOBgNVHQ8BAf8EBAMCAYYwEgYD VR0TAQH/BAgwBgEB/wIBADARBgNVHSAECjAIMAYGBFUdIAAwTAYDVR0fBEUw QzBBoD+gPYY7aHR0cDovL2NybC5jb21vZG9jYS5jb20vQ09NT0RPUlNBQ2Vy dGlmaWNhdGlvbkF1dGhvcml0eS5jcmwwcQYIKwYBBQUHAQEEZTBjMDsGCCsG AQUFBzAChi9odHRwOi8vY3J0LmNvbW9kb2NhLmNvbS9DT01PRE9SU0FBZGRU cnVzdENBLmNydDAkBggrBgEFBQcwAYYYaHR0cDovL29jc3AuY29tb2RvY2Eu Y29tMA0GCSqGSIb3DQEBDAUAA4ICAQB4XLKBKDRPPO5fVs6fl1bsj6JrF/bz 9kkIBtTYLzXN30D+03Hj6OxCDBEaIeNmsBhrJmuubvyE7HtoSmR809AgcYbo W+rcTNZ/8u/Hv+GTrNI/AhqX2/kiQNxmgUPt/eJPs92Qclj0HnVyy9TnSvGk SDU7I5Px+TbO+88G4zipA2psZaWeEykgzClZlPz1FjTCkk77ZXp5cQYYexE6 zeeN4/0OqqoAloFrjAF4o50YJafX8mnahjp3I2Y2mkjhk0xQfhNqbzlLWPoT 3m7j7U26u7zg6swjOq8hITYc3/np5tM5aVyu6t99p17bTbY7+1RTWBviN9YJ zK8HxzObXYWBf/L+VGOYNsQDTxAk0Hbvb1j6KjUhg7fO294F29QIhhmiNOr8 4JHoy+fNLpfvYc/Q9EtFOI5ISYgOxLk3nD/whbUe9rmEQXLp8MB933Ij474g wwCPUpwv9mj2PMnXoc7mbrS22XUSeTwxCTP9bcmUdp4jmIoWfhQm7X9w/Zgd dg+JZ/YnIHOwsGsaTUgj7fIvxqith7DoJC91WJ8Lce3CVJqb1XWeKIJ84F7Y LXZN0oa7TktYgDdmQVxYkZo1c5noaDKH9Oq9cbm/vOYRUM1cWcef20Wkyk5S /GFyyPJwG0fR1nRas3DqAf4cXxMiEKcff7PNa4M3RGTqH0pWR8p6EjCCBlQw ggU8oAMCAQICEAf6KCF9+1doL2oEOTPysLwwDQYJKoZIhvcNAQELBQAwgZcx CzAJBgNVBAYTAkdCMRswGQYDVQQIExJHcmVhdGVyIE1hbmNoZXN0ZXIxEDAO BgNVBAcTB1NhbGZvcmQxGjAYBgNVBAoTEUNPTU9ETyBDQSBMaW1pdGVkMT0w OwYDVQQDEzRDT01PRE8gUlNBIENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQg U2VjdXJlIEVtYWlsIENBMB4XDTE3MDUyMzAwMDAwMFoXDTIwMDUyMjIzNTk1 OVowggFZMQswCQYDVQQGEwJTRTEPMA0GA1UEERMGNjgzIDMxMRIwEAYDVQQI EwlWYWVybWxhbmQxEDAOBgNVBAcTB0hhZ2ZvcnMxGDAWBgNVBAkTD05vcnJp bmdzIHZhZWcgMjEPMA0GA1UEEhMGQm94IDMwMSYwJAYDVQQKDB1LbGFyw6Rs dmRhbGVucyBEYXRha29uc3VsdCBBQjEdMBsGA1UECxMUQSBLREFCIEdyb3Vw IENvbXBhbnkxQzBBBgNVBAsMOklzc3VlZCB0aHJvdWdoIEtsYXLDpGx2ZGFs ZW5zIERhdGFrb25zdWx0IEFCIEUtUEtJIE1hbmFnZXIxHzAdBgNVBAsTFkNv cnBvcmF0ZSBTZWN1cmUgRW1haWwxFTATBgNVBAMTDE1pbGlhbiBXb2xmZjEk MCIGCSqGSIb3DQEJARYVbWlsaWFuLndvbGZmQGtkYWIuY29tMIIBIjANBgkq hkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAxrzfNBVvRbiAknuTBXuQnNm9sLIF Lo0vbPB6kswk78A3tA++Zn5clQUHhGlQq1cdYxagnUpqwvG3Sod15mPSOLkA Pf/mabLN7p+lFbRaUP+97ZkTZtvb4BCC3osIEFI4G393OSFWqc2qmIPE/SwS ASbAA20Fcaa2M6P1lhOk/ttUh2jIurTPF0wUycIA7lBddrOgaOA8e2m6iLTN HtlrfRbBaUX91D5ebY+UWmIjXSQ9+CtutMzBkwnF0rZKririvOkklg9VzEGN QVHrQfDF2s/UpOtmtuVSwElauGT/KALyCFuIrYC1pmaKH8S1xODJqiRaf6jH 8E+KQzKjyM/ErwIDAQABo4IB1TCCAdEwHwYDVR0jBBgwFoAUgq9sjPjF/pZh fOgfPStxSF7Ei8AwHQYDVR0OBBYEFN+m99RtIuA1bSdw6b1brOX7X3AJMA4G A1UdDwEB/wQEAwIFoDAMBgNVHRMBAf8EAjAAMB0GA1UdJQQWMBQGCCsGAQUF BwMEBggrBgEFBQcDAjBGBgNVHSAEPzA9MDsGDCsGAQQBsjEBAgEDBTArMCkG CCsGAQUFBwIBFh1odHRwczovL3NlY3VyZS5jb21vZG8ubmV0L0NQUzBaBgNV HR8EUzBRME+gTaBLhklodHRwOi8vY3JsLmNvbW9kb2NhLmNvbS9DT01PRE9S U0FDbGllbnRBdXRoZW50aWNhdGlvbmFuZFNlY3VyZUVtYWlsQ0EuY3JsMIGL BggrBgEFBQcBAQR/MH0wVQYIKwYBBQUHMAKGSWh0dHA6Ly9jcnQuY29tb2Rv Y2EuY29tL0NPTU9ET1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5kU2VjdXJl RW1haWxDQS5jcnQwJAYIKwYBBQUHMAGGGGh0dHA6Ly9vY3NwLmNvbW9kb2Nh LmNvbTAgBgNVHREEGTAXgRVtaWxpYW4ud29sZmZAa2RhYi5jb20wDQYJKoZI hvcNAQELBQADggEBABf47LSJADqH+ow9INv3QM1NC/qq2bjxGvsZ68iD11VE UAFlsYfsVTgQqUirwPVTYenXtwVBELHZyywsui1JxL7HKQetLQegDDP/Ryfj ReVaWxhy3OpuItsgLVbru9QVgPifnoBFPtfZcwjeJDmeSbLT8oj4Rd0KYBOI ve7WKvsfNPsNwfbLwY2zILkELjxZcVi2AwZHDyab+dzL/3YcLuJj1lSawBGn 7ilpcdZydlv4aye51pD/MemLIYLcylt+ImrmjnTVy+QlAHRF3s5FE8yAr+W1 MBD/1bKZCSgFt8VQoAlz3hiQh8QqZp4Zl8WuVL4+mP/mT6VDEWgq/0Bocukx ggJuMIICagIBATCBrDCBlzELMAkGA1UEBhMCR0IxGzAZBgNVBAgTEkdyZWF0 ZXIgTWFuY2hlc3RlcjEQMA4GA1UEBxMHU2FsZm9yZDEaMBgGA1UEChMRQ09N T0RPIENBIExpbWl0ZWQxPTA7BgNVBAMTNENPTU9ETyBSU0EgQ2xpZW50IEF1 dGhlbnRpY2F0aW9uIGFuZCBTZWN1cmUgRW1haWwgQ0ECEAf6KCF9+1doL2oE OTPysLwwDQYJYIZIAWUDBAIBBQCggZMwGAYJKoZIhvcNAQkDMQsGCSqGSIb3 DQEHATAcBgkqhkiG9w0BCQUxDxcNMTgxMTA3MDkwMjU0WjAoBgkqhkiG9w0B CQ8xGzAZMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzAvBgkqhkiG9w0BCQQx IgQgXcKRmxCmF7Hnq851NQND4YUwCt7MDTziNR3uae50mVQwDQYJKoZIhvcN AQEBBQAEggEAfomB7GGyXJB2dKsPkxjtm/R7zrnBOTU3v+C5Xnl25sn7k8i/ KtdCdTGUSTtpmK0rIm0Y50v6ZmqKu7HhKHmfjmkonEy/mcfzCQ8D0ETXifbn 11Kp0MUuUqiOb1xL2UGQlvpeJ6iD/DwhhvPmO2QUHKJBR2NsdUe3mZga6SCj Sv1gVAOVDCM6B2po6jpypD7RK1w5rmDjFYVgoiplNTzdBxFXonSeYNd51Dqb xGIHcbTNymVmuY0q++wM4Gt/7GBHVR3tlRdW08jyFL0IfheExMk3+QXQztkL kX5ALLXYkrr+GoG9e8tbAJfBds+ln1hvW+F498dBlCt4efev692CrAAAAAAA AA== --nextPart2529565.WcsbrJ28ph--