From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id F250E3858C60 for ; Thu, 2 Sep 2021 11:29:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F250E3858C60 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl [83.87.18.245]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id F321E30008A9; Thu, 2 Sep 2021 13:29:23 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 5A17E4001437; Thu, 2 Sep 2021 13:29:23 +0200 (CEST) Message-ID: <67cbd2e7bbe3e354bc004684749a4e41ab0026c4.camel@klomp.org> Subject: Re: debuginfod: Fracture tests/run-debuginfod-find.sh into specific tests From: Mark Wielaard To: Noah Sanci , elfutils-devel@sourceware.org Date: Thu, 02 Sep 2021 13:29:23 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Sep 2021 11:29:40 -0000 Hi Noah, I am excited about this patch, but wondering about this part: > diff --git a/ChangeLog b/ChangeLog > index 12b8f403..0aeac175 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,6 @@ > +2021-08-23 Noah Sanci + * ChangeLog: removed --sign flag on rpmbuild > + > 2021-07-28 Mark Wielaard > =20 > * configure.ac (AC_CHECK_DECLS): Add reallocarray check. > diff --git a/Makefile.am b/Makefile.am > index 9c47afa9..3dfefa9f 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -45,7 +45,7 @@ distcheck-hook: > chmod -R u+w $(distdir) > =20 > rpm: dist > - rpmbuild -ts --sign elfutils-@PACKAGE_VERSION@.tar.bz2 > + rpmbuild -ts elfutils-@PACKAGE_VERSION@.tar.bz2 > =20 > if GCOV This might be a ok thing to do. I am not sure who is actually using the rpm target (we release src.tar.bz files, not srpms). But it seems unrelated to the rest of the patch. Cheers, Mark