From: Torsten Polle <Torsten.Polle@gmx.de>
To: Mark Wielaard <mark@klomp.org>
Cc: elfutils-devel@sourceware.org
Subject: Re: [RFC] libdw: prepend current directory in read_srclines
Date: Wed, 29 Mar 2017 20:15:00 -0000 [thread overview]
Message-ID: <68860EF1-F2CA-4EB4-9420-F1783C4AF9F1@gmx.de> (raw)
In-Reply-To: <20170327204510.GA2448@stream>
Hi Mark,
> Am 27.03.2017 um 22:45 schrieb Mark Wielaard <mark@klomp.org>:
>
> Hi Torsten,
>
> On Sun, Mar 26, 2017 at 08:35:50PM +0200, Torsten Polle wrote:
>> I observed that readelf and elfutils sometimes report different results.
>
> Do you have an example of this? It would be good to have a testcase.
>
>> PFA a patch that corrects this. I’m not sure whether the way I tackled
>> the problem is acceptable.
>
> I see why you are proposing this. The DWARF spec does say about the
> include_directories "Each path entry is either a full path name or is
> relative to the current directory of the compilation". So your patch
> does make sense.
>
> But it does depend on what users of dwarf_getsrclines expect.
> Or any use of Dwarf_Line/Dwarf_Files. I think those users expect that
> the returned file names can be relative. And that they should make them
> absolute using index zero or the comp_dir themselves.
>
> So if you do have an example where the expected output isn't what you
> believe it should be we should examine if there is some other way to
> do the right thing.
>
> Cheers,
> Mark
thanks for the answer. I’ll come back with an example, which is SystemTap based. :-)
Please allow for some delay. I expect to provide an example in about two weeks.
Regards,
Torsten
next prev parent reply other threads:[~2017-03-29 20:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-26 18:35 Torsten Polle
2017-03-27 20:44 ` Mark Wielaard
2017-03-29 20:15 ` Torsten Polle [this message]
2017-05-04 8:26 ` Torsten Polle
2017-05-05 13:37 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68860EF1-F2CA-4EB4-9420-F1783C4AF9F1@gmx.de \
--to=torsten.polle@gmx.de \
--cc=elfutils-devel@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).