From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 552 invoked by alias); 29 Mar 2017 20:15:41 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 448 invoked by uid 89); 29 Mar 2017 20:15:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-7.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_1,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-spam-relays-external:mail.gmx.com, H*RU:mail.gmx.com, H*r:212.227.17, H*r:mail.gmx.com X-Spam-Status: No, score=-7.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_1,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: mout.gmx.net Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\)) Subject: Re: [RFC] libdw: prepend current directory in read_srclines From: Torsten Polle In-Reply-To: <20170327204510.GA2448@stream> Date: Wed, 29 Mar 2017 20:15:00 -0000 Cc: elfutils-devel@sourceware.org Content-Transfer-Encoding: quoted-printable Message-Id: <68860EF1-F2CA-4EB4-9420-F1783C4AF9F1@gmx.de> References: <20170327204510.GA2448@stream> To: Mark Wielaard X-Mailer: Apple Mail (2.3259) X-Provags-ID: V03:K0:u4F9EP0eDnK1M8kGPlMASHnQ1TPyKpaqb2iU5dSi6ZtXCcZ+yeg Zjg/hYups/gQh3/MPa//TvlelVPSuLQeGv4wBz9N0grCGTdQAGTeWo2X+e25x8TbDDFkAT5 wyvRbd5fwGihRWoYLUh7HUr2azkxrwP1x0kFLWVHcmlWau76unLX4nQpg+rZXrFKRgvHFN8 jxSq+ysaXsV5pVDITcH0A== X-UI-Out-Filterresults: notjunk:1;V01:K0:HH47UJy9VjA=:VUn05TfUxYk/frJYZFq5vm 8JYIk+kzPF3WNRX2iyoM3C7HZ+vIOTycy6iomI7W4NiLWY94wjOVK+Eo89a3cb0gdo7y1KwC6 8N8b5QrZFyF6ZOAQk/C20v5pcM8oTK9uUq0DM0vHcW5jlpdrKU4HPm6KwO/YsgZgQHNV+UdDs q/3DxN6SGyoSKFP8wmr5vIC1723aku3brk8pR9nRcvTjn4YpEL7mfxjWWUAIRbE518yBhG+RS M3ifpsfptNgtqQPPchdvXGLipVaDW/oLIwi45maCx5GY/XPDYg1O6pKXuV5U7gUE6UXO2IMgn yRFN+mlA0uhM7Q6Npyr/X/x2ju27if5XsfA3KjWqXUQdWlKiCao1qcGARAFPUp/zSSoikbhXy 2KIogQLBVgOq7lmgZ3oW4B9tybvCtnrzwE0k9Pv2ZbguFjSJ6rA+W+6BWQs1rDH0NiTvfTDsm 4XckCWeg0cbeD7cytfSLmL5K2MbVET6SVR5T1Wf+5wSTFNgNAhYLXe46OFri41mE+hFPawmZE 7Kb2hNh7KgKUzEBSbuFC8FApDLchFBBYMXveK/TgWtVNDu7/NCCOoNYr/YRwNs+DcOOF+qVWB xWS6f8sDcVxP+sZkA1K98DRQOR9F1A07be7u6lHkIU6CC3DVDatRod5k+E69A1fv1wlebf5iu wnVY1qDNte3DDQ1S932Ig621PVgs5lCTAdaGINQYNnO7TLRnvgLK+PJmnFvwEPl7aiG+y/3ij VJKDyqSU/BQXIxRguhwLhrolThVlgQFjgZUmNSVBAoYl+cfnuHS1i6SFduoS87Em5cGa1evd6 x5ZQts0 X-SW-Source: 2017-q1/txt/msg00144.txt.bz2 Hi Mark, > Am 27.03.2017 um 22:45 schrieb Mark Wielaard : >=20 > Hi Torsten, >=20 > On Sun, Mar 26, 2017 at 08:35:50PM +0200, Torsten Polle wrote: >> I observed that readelf and elfutils sometimes report different results. >=20 > Do you have an example of this? It would be good to have a testcase. >=20 >> PFA a patch that corrects this. I=E2=80=99m not sure whether the way I t= ackled >> the problem is acceptable. >=20 > I see why you are proposing this. The DWARF spec does say about the > include_directories "Each path entry is either a full path name or is > relative to the current directory of the compilation". So your patch > does make sense. >=20 > But it does depend on what users of dwarf_getsrclines expect. > Or any use of Dwarf_Line/Dwarf_Files. I think those users expect that > the returned file names can be relative. And that they should make them > absolute using index zero or the comp_dir themselves. >=20 > So if you do have an example where the expected output isn't what you > believe it should be we should examine if there is some other way to > do the right thing. >=20 > Cheers, > Mark thanks for the answer. I=E2=80=99ll come back with an example, which is Sys= temTap based. :-) Please allow for some delay. I expect to provide an example in about two we= eks. Regards, Torsten