From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id 8605D3858C60 for ; Fri, 27 Aug 2021 15:19:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8605D3858C60 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl [83.87.18.245]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 4B3CF3000ADE; Fri, 27 Aug 2021 17:19:56 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id DB0C2413CE32; Fri, 27 Aug 2021 17:19:55 +0200 (CEST) Message-ID: <68e76734befedfc55e31ae12ce6499991536ac5b.camel@klomp.org> Subject: Re: [PATCH] debuginfod, elfclassify: remove unnecessary header inclusion From: Mark Wielaard To: Saleem Abdulrasool , elfutils-devel@sourceware.org Date: Fri, 27 Aug 2021 17:19:55 +0200 In-Reply-To: <20210820182120.2841876-1-abdulras@google.com> References: <20210820182120.2841876-1-abdulras@google.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Aug 2021 15:19:58 -0000 Hi Saleem, On Fri, 2021-08-20 at 18:21 +0000, Saleem Abdulrasool via Elfutils-devel wr= ote: > `error.h`'s inclusion was centralised into the `system.h` header. As > the implementation currently includes `system.h` already, the inclusion > of `error.h` is unnecessary. This prepares for a future portability > change to allow elfutil to build with alternate libc implementations. >=20 > Signed-off-by: Saleem Abdulrasool Thanks. Added ChangeLog entries and pushed. Cheers, Mark