From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63231 invoked by alias); 15 Nov 2019 16:49:45 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 63212 invoked by uid 89); 15 Nov 2019 16:49:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy=organized X-Spam-Status: No, score=-11.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Nov 2019 16:49:43 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id C3169300073F; Fri, 15 Nov 2019 17:49:40 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 18B17405CC5B; Fri, 15 Nov 2019 17:49:40 +0100 (CET) Message-ID: <6c66a738f766fc7ab4fc312de3a406285589dbd0.camel@klomp.org> Subject: Re: patch 4 debuginfod: symlink following mode From: Mark Wielaard To: "Frank Ch. Eigler" , elfutils-devel@sourceware.org, amerey@redhat.com Date: Fri, 15 Nov 2019 16:49:00 -0000 In-Reply-To: <20191107090732.GA19337@redhat.com> References: <20191028190438.GC14349@redhat.com> <20191028190602.GD14349@redhat.com> <20191028190726.GE14349@redhat.com> <20191104214823.GA17633@redhat.com> <20191107090732.GA19337@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-5.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2019-q4/txt/msg00142.txt.bz2 Hi Frank, On Thu, 2019-11-07 at 04:07 -0500, Frank Ch. Eigler wrote: > From: "Frank Ch. Eigler" > Date: Wed, 6 Nov 2019 18:53:31 -0500 > Subject: [PATCH 1/2] debuginfod 4: symbolic link traversal mode >=20 > In order to support file/rpm archives that are organized via symlink > trees, add an "-L" option to debuginfod, meaning about the same as for > find(1) or ls(1): to traverse rather than ignore symlinks. Could you give an example of when exactly this is necessary? I assume that it isn't really necessary for rpm archives, you probably don't want to follow any symlinks from an archive that point to something outside the archive, and you will see all files in the archive anyway. So following symlinks doesn't seem helpful there. Also why combine symlink following with cross-device searches? Shouldn't that be separate options? > --- a/tests/run-debuginfod-find.sh > +++ b/tests/run-debuginfod-find.sh > @@ -22,10 +22,11 @@ set -x > testfiles testfile-debuginfod-0.rpm testfile-debuginfod-1.rpm testfile-d= ebuginfod-2.rpm >=20=20 > DB=3D${PWD}/.debuginfod_tmp.sqlite > +tempfiles $DB > -######################################################################## > - > -# Ensure debuginfod-find can be safely called with no arguments. > -# Use a relative path to prevent automatic line breaks in the output > -# due to excessive characters. > -testrun_compare ../../debuginfod/debuginfod-find < -Usage: ../../debuginfod/debuginfod-find debuginfo BUILDID > - or: ../../debuginfod/debuginfod-find executable BUILDID > - or: ../../debuginfod/debuginfod-find source BUILDID /FILENAME > -EOF > - This wasn't a very useful test, but did you really intend to remove it? Cheers, Mark