From: Mark Wielaard <mark@klomp.org>
To: Nick Clifton <nickc@redhat.com>, elfutils-devel@sourceware.org
Subject: Re: [PATCH] Handle GNU Build Attribute ELF Notes.
Date: Tue, 13 Nov 2018 12:49:00 -0000 [thread overview]
Message-ID: <6d0aa0643969a7c0e3c5fdce9497ccb95a1e330e.camel@klomp.org> (raw)
In-Reply-To: <c6df5498-b763-7685-ec26-d2249fbcbc4e@redhat.com>
On Tue, 2018-11-13 at 11:56 +0000, Nick Clifton wrote:
> + /* There might or might not be a pair of addresses in the desc. */
>
> FYI - There was an old version of the Watermark specification that only put
> one address into the note's desc field. This version was never used in
> production binaries, so it is unlikely that such notes will ever be found in
> the wild.
If it never happens in production binaries lets ignore this quirk.
> Anyway although I am not an official elfutils reviewer the patch
> looks great
> to me. I hope that it will be accepted into the sources.
Lets do that then :) It also resolves the self-test failure on Fedora
29, so it should make the buildbot happy again. Pushed to master.
Thanks,
Mark
next prev parent reply other threads:[~2018-11-13 12:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 23:35 Mark Wielaard
2018-11-13 11:56 ` Nick Clifton
2018-11-13 12:49 ` Mark Wielaard [this message]
2018-11-14 23:25 ` Mark Wielaard
2018-11-15 12:31 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d0aa0643969a7c0e3c5fdce9497ccb95a1e330e.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).