From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60907 invoked by alias); 13 Nov 2018 12:49:05 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 60482 invoked by uid 89); 13 Nov 2018 12:48:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=HTo:U*nickc, Hx-languages-length:782 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Nov 2018 12:48:48 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id F13FA304D68A; Tue, 13 Nov 2018 13:48:41 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id DCF8C413CD4B; Tue, 13 Nov 2018 13:48:41 +0100 (CET) Message-ID: <6d0aa0643969a7c0e3c5fdce9497ccb95a1e330e.camel@klomp.org> Subject: Re: [PATCH] Handle GNU Build Attribute ELF Notes. From: Mark Wielaard To: Nick Clifton , elfutils-devel@sourceware.org Date: Tue, 13 Nov 2018 12:49:00 -0000 In-Reply-To: References: <1542065698-4660-1-git-send-email-mark@klomp.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-2.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2018-q4/txt/msg00117.txt.bz2 On Tue, 2018-11-13 at 11:56 +0000, Nick Clifton wrote: > + /* There might or might not be a pair of addresses in the desc. */ >=20 > FYI - There was an old version of the Watermark specification that only p= ut > one address into the note's desc field. This version was never used in > production binaries, so it is unlikely that such notes will ever be found= in > the wild. If it never happens in production binaries lets ignore this quirk. > Anyway although I am not an official elfutils reviewer the patch > looks great > to me. I hope that it will be accepted into the sources. Lets do that then :) It also resolves the self-test failure on Fedora 29, so it should make the buildbot happy again. Pushed to master. Thanks, Mark