From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25365 invoked by alias); 20 Jun 2018 14:18:39 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 25354 invoked by uid 89); 20 Jun 2018 14:18:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.4 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-12.6 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: mx0a-00082601.pphosted.com Received: from mx0a-00082601.pphosted.com (HELO mx0a-00082601.pphosted.com) (67.231.145.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Jun 2018 14:18:36 +0000 Received: from pps.filterd (m0109334.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w5KEDKo0015274; Wed, 20 Jun 2018 07:18:32 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=subject : to : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=facebook; bh=/sypwv2d12FIsz2LlLU4h5nyffMZ3Y1ncBsvISr9jGw=; b=GnM8DiBcg/DPY/yFfnrG7ceMRb9FfPtU36sP8VKoFgkgi4CNtPPWKFuvGNh6o6ceKtVC IR1N1OD3omktbarV2gN6ZhqqvIYk8SKXcp79Xe227SnJl7jOHuxkZ65g9GspgaztTGaa Oak2RoBxkHtbCX7+nMLWuNr0sAV4OJ0Mn6Y= Received: from maileast.thefacebook.com ([199.201.65.23]) by mx0a-00082601.pphosted.com with ESMTP id 2jqq4pr7w6-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 20 Jun 2018 07:18:32 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (192.168.183.28) by o365-in.thefacebook.com (192.168.177.25) with Microsoft SMTP Server (TLS) id 14.3.361.1; Wed, 20 Jun 2018 10:18:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.onmicrosoft.com; s=selector1-fb-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/sypwv2d12FIsz2LlLU4h5nyffMZ3Y1ncBsvISr9jGw=; b=b+qZGyvNB4jIwb8geqLoHarPgHBNr2d5pWcImuo2vtsTRvt9go1D8++3JNP4B4xsFdR9UfaWVYHkoOEJccTylnaOND6cHUoZjiBfBPQ7J6F3/Gv3A/VJJE4W3ZyMQ5NjPXPc3cmkoZhpzh0eno7AiBAwJkAqUXSlp8z6a6huhAo= Received: from dhcp-172-20-173-177.DHCP.thefacebook.com (2620:10d:c090:180::1:6f19) by CO2PR15MB0073.namprd15.prod.outlook.com (2a01:111:e400:5068::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.16; Wed, 20 Jun 2018 14:18:26 +0000 Subject: Re: [PATCH v2] backends,bpf: add proper relocation support To: Mark Wielaard , , , References: <20180616200243.1389518-1-yhs@fb.com> <1529494894.12946.134.camel@klomp.org> From: Yonghong Song Message-ID: <6ea2640a-fd92-82b9-0041-0d74bfff17c3@fb.com> Date: Wed, 20 Jun 2018 14:18:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <1529494894.12946.134.camel@klomp.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [2620:10d:c090:180::1:6f19] X-ClientProxiedBy: MWHPR18CA0036.namprd18.prod.outlook.com (2603:10b6:320:31::22) To CO2PR15MB0073.namprd15.prod.outlook.com (2a01:111:e400:5068::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 76647586-0f6c-4793-03c4-08d5d6b8b1b7 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(711020)(2017052603328)(7153060)(7193020);SRVR:CO2PR15MB0073; X-Microsoft-Exchange-Diagnostics: 1;CO2PR15MB0073;3:HZ4/fmFeTpadD9vDHQrUjmpTwzAE2LyMEEc7GkFK8rDG39PLtoXQ49b81WB23Mi95rRxZkdpqK+y9/dfks40sUK/BRbxKqgdtg06EciSxRjT0nSDLM4X5XU9EMU8Q+WilVT0RhubOCCUlntkw6eIkbCwYYbiSEB8YtS5mXogbBqE5x5UFLP6UEnp6SkY2Bzrc8Za0RZqRtvCj2TU8Q0NBVpuNOgv3UkLiqVogGw2wiG6qOodM0ANO+SEzuP036X1;25:ZGV5mssmstIpwaZFkkXX2JMBwlYLD1klKz9BWBw8X5cELcAM59y5R6afKJSK1o1cyClvYx/GCjG8aZZcOHKrJYYJTGlKBAgRNmVOmgim/Zl3AK47eTRxsFw8wgflUviXTrFMWeTFZBgFxWG1s4An6ULTjuLBXRHndiXyB47bgE2+G/NkrSNdVE9/cRWySzx7/xnl0QGNsrl2S56D2BvyoNMMCHkNwgXZnBnj5iQ4rp0NNHCcpCLA+QcxJbJg6PXGxa5ozLKZ48zTpCgNVRuFcX1fESTFrc4HdJMBOdci5SFxSD/CYA8jLRGv+0nhXm3nD1ayRCuv0LLIFQY92HbgGw==;31:glTTzheAitugvktiuGfNMb1XvZ2KWdxffdevBucOMcph3BKb33nkNdOowzytYe53X1qg+B1hLFdwhU2R+9Bhh4XaWjiLGByJZTjiJKxXfM/QwRlhj9mgp6c2nuuSzIjkrG5epB+bqwxIlTQT8oHPEjqW569T8Z1LkDkPzBSPKIb4wKM2G44ws3OHEBcpeOnJ5ojgjxOBMAm4XsMV2x6n6O25e8B9dr5C1rOtSOEMFyw= X-MS-TrafficTypeDiagnostic: CO2PR15MB0073: X-Microsoft-Exchange-Diagnostics: 1;CO2PR15MB0073;20:iitqyE8eDguEIbUTQC90QIpMFCppjHFS4c7DGM9ygL5bLHD4Oe21QqCZ7NLYOFtldO2T+WKYXnObE0OZuTXP+5YoO2inKTQFnBUFv+UlTOhDTuoLXhGrfQlsi93U7BthSENJCkUe8yaEpEm1TaBdNP+NYJmaX2/D6+yz63INSKQsxQAVT7dM8ZBS1ZYvbgtZBqEyryYv/HSj3HylD7If5VEnub+kjwKMSSWJzt45UB2Mm2Wqz8Rg6S7n2fqIkiXK1Ph8wnwgPYOVsmZ92bX5sLBl/PCqG3j/AS3ft8Yqd1JMlSKJ4Z8ZMcwm0FuvEftZj3+yXSKnlr8PARsNMhR+wOhQo616V0vxDxG/eCGhyc0RPmVsKQiYEbhDgrQvY06SuC8nNQ/4iyvzdtyQJL8JF3RKjRol44ze1TUzFoULb0hBssqZoz2+cCBgD+yOZm0/8Su51bzMxtCyfr8c8b63z8Bkvr+/WNBk5bDizKe6ljIuY80EGYUkITfkOHgI4k9/;4:YjxksqHB1h8FQD4gisaxf0RR/KC0G7JV9lRCJAOpYaw6ISgOjRkHTuqYAg59WE5yHnqXrDM3sEarcCFAJYyJCJxY4IZqD2cSOovjckq7PcX8d93CuWQMBzLLQf4SB7CrVx8L70WIVqojP3CWTWc5xmovu4fuSNdX4Cpq9ZLIVu8qoA9x5q22Cr8jpgHuEmL+/8NKgXf9EV2Dh86ELgVvqQG6Xc5T5lyKWnJkGQOri8+8CUkEOOjaGvVgz4pauMV3mawNroOo3df+AUaLqybkNxUJ5y4fjI6qzcay7xEBKZv1qlqTcVZfJ7xRBMqGNA8X7TLUYKgAUYHV9ZAXziBpr8/kCzFIF1OgobV/3wH2sIWJT5tY9rOY+IF9/HklyNEr X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(10436049006162)(67672495146484)(262104967686372); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3231254)(11241501184)(944501410)(52105095)(3002001)(93006095)(93001095)(149027)(150027)(6041310)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016);SRVR:CO2PR15MB0073;BCL:0;PCL:0;RULEID:;SRVR:CO2PR15MB0073; X-Forefront-PRVS: 070912876F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(346002)(376002)(366004)(39380400002)(396003)(39860400002)(199004)(189003)(54534003)(6512007)(81156014)(81166006)(64126003)(65956001)(6116002)(2906002)(97736004)(50466002)(65806001)(8936002)(2870700001)(53936002)(478600001)(6306002)(68736007)(6246003)(47776003)(53546011)(6506007)(31686004)(59450400001)(16526019)(86362001)(386003)(11346002)(446003)(46003)(52116002)(2616005)(486006)(305945005)(7736002)(25786009)(575784001)(31696002)(5660300001)(36756003)(229853002)(106356001)(65826007)(105586002)(8676002)(76176011)(6666003)(52396003)(316002)(6636002)(58126008)(6486002)(476003)(23676004)(52146003)(2486003)(67846002)(142933001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:CO2PR15MB0073;H:dhcp-172-20-173-177.DHCP.thefacebook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; Received-SPF: None (protection.outlook.com: fb.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDTzJQUjE1TUIwMDczOzIzOnV2dVZ6Vnp4NCtYaTloM2ZXYjlvd2MvTDgy?= =?utf-8?B?bnJidGR1dWtyUFpVKy9wdGNIRzFLMktqbkg1UHFCeVBUMHUwZGFuRWtCYlQw?= =?utf-8?B?RHdFZ1R5ME9GSGRwOFpSRXVQVjRhTjZLb3B3NW54Q3dNY1NPbElLcFFwa0hC?= =?utf-8?B?YldiajdpVmUwOVBKbzl5cVNGKzU4SGgvUUVzQjVPY1R3Mmc1M3JMZWozV3Z3?= =?utf-8?B?TXVrd1RzTXQ2UDNqTVVteXkrQ0t0bFlzV2VzcWt0ME50Y2ZpWXd5SWNmWC91?= =?utf-8?B?eDUydjNkQ1VOK3NxWllXRERTa1oybHl1ZzlXUTZDc2xwNTJ0ZWtsSHdaeldh?= =?utf-8?B?UzdoVHZQcW53dVRaSXV6UjlrYU1tZDFGK25RdlFnWmxtWUk2UlVmYWplSWtJ?= =?utf-8?B?dFlqcVhtTEd4UjMxbFdzMHlDWkpTN3haZkJSaGE1L1pYUm9UQzlGT2tsVW5E?= =?utf-8?B?VzRsZk42eW5LVlpGMTFQck8wcXhVVzJUU2dpMldvaGpzMitDNkEvMlNKbk9M?= =?utf-8?B?bU1MVGRWenZaczIxaDJUREc3T3Nndy92amtIaGMrZ1B4cXRMUHZhVzVvZ3Er?= =?utf-8?B?OVRobWVjbG1XNCs4WEQ5Q0ZFNE5RN1VNVStmRVMvSG9tRnhFL2tWdHFRWGZ5?= =?utf-8?B?b3dFK2JhWlgxRnB3YzRZcnczRkRiMmRSSVl4ZXhvTHZReFpmRjZ1Qkh6TFl6?= =?utf-8?B?bldZeWJvb09wUm9NZzBJUG5rR3Y1cHAxbnpLWml3Q09uZDNUOXhUdVRlVk4z?= =?utf-8?B?eFdIOTRRNndFaE0xMXZ1c0NhMXlLd1ljVnV4eERDTHpqZUNqZVBmTFo5NGlU?= =?utf-8?B?RFNCWFRVTHpCbDJ5U0lTa2hEdzRmcEZJK29DRCtvSHpEeTBwTDhBZFRZcDNt?= =?utf-8?B?TFZJbWxyMXBNRDdwNVd2YmNMT2tlbkZ5WlVuS2tjSk55c0xRYm9OOWtPcVBu?= =?utf-8?B?Qi9oQWJPSERsVWJZREthV2dsTWhiWkJLZVF0OU1IWE1YNHF2Q1VqU05aYUtv?= =?utf-8?B?dUZYbkRzOXkySWkwV0VjT215UElCZUpwR2FBSG1tUWFjZDU4YU9DS25yelBS?= =?utf-8?B?SHRDT1VYcDFIYkxNdm9WcTJOTU5SbmJmbzJUYjN1UDZUaUxsbTloN1dzaEVp?= =?utf-8?B?QzBqMEhJei9qNXBNWmowVkhPNkJLVHpGaUFGNVF4RC9vUUx3MjRuK1RCY2Q1?= =?utf-8?B?Z1hHY0hyNXYzQ3BIOVhzMnRYRFB4STRqeDgzelk4VHBNTXNpbHdIVUVLZXZ1?= =?utf-8?B?THFOS05lSCtlWjg2RGZmV2dFTnIrZVFzNlJtb25ZQ1pTbUhGSGtwNk54UTdD?= =?utf-8?B?aEhjVTArcmJLbmYzWjZHU2laZDJQWm1UbDVaZHRwTkhkRHpsNUZVZktRMzlx?= =?utf-8?B?VUdCS2lwMUJSUGxDZFNsOUkrOXM2NWRETm1TamQwb0l3VzhPWnhNREJOQWlB?= =?utf-8?B?d1ZLRmlPVUVJb1d5TjEwNjc2K1J6V1VsMnB1NDFZUllFZlB0QlhRZkRCcDYz?= =?utf-8?B?Vi9MNG1XQkRDSXJyZW15QlNsU1orZXUwaHJrNk5JVDkwTlIvU0FmdXBhclBr?= =?utf-8?B?RUhSdW9iWTZjdDcvcW1kWnZxU2V1aU5pd2NpNThvZ0pNWnkyM2t6Zm92Y1Vj?= =?utf-8?B?RUR4eCtiUmxZT3BOWWRIVkc0NHV1WkEyZWNTMzgxTU1qb2QxTFAweEc3Zk04?= =?utf-8?B?NHpPTVRYaTRkUWpPOTJlZlE0TndOekxNdHo4Q28wbmg5YlNveFJYVWlPWTdw?= =?utf-8?B?NkJGbGdWdnplajVTOTg5WjFsMkRCeWF1SmF6bHRUbmhzaTI0VHBUWmszcEpF?= =?utf-8?B?aE5YN0pvKzdtN0NwcG95Nk54VTFkcTJkSHFPc2J6WXI0bFF5NmFnNXJWZ0Ux?= =?utf-8?B?bkZ0QXFZWEdKelNUYjN4cTVCWEFMZ2JhWG1vd3dRVkdxVE9xeCtETDJ1aElP?= =?utf-8?B?K3BPMFJRbzBpSnRvQ2Q0M0VRTWQ3U3FoWW1YR1lZNWx2cE9yMldZL29ScWtP?= =?utf-8?B?M1RrYVBtM3I3Q0t3aUJ6bVo2WUp0NzlqWEJ4Zz09?= X-Microsoft-Antispam-Message-Info: ue+B9zhYPUKlkw2QYA1w7JMnW4KZIhfxQmzz2a8d98nzy42YkcRygrJ6qSh/pJi+ONGYNWz647FhfEDXIrZX/Av94yh35z4BIgliet+W0b0JUbg+WH29G5/QwgYWoltjlydnTkT9x4o5yQFozqUZMA4Mw1qGlsbShR8aaFmXiKsKE+UKBVCE2WmI58OkwpUcb+mrxi2JMwi2dWzkG5vS3cWqM7jYJ0AG+UtJSTEDFbTPx7r7aO61imSqY+2RyNA25WJCtUKdbim9sEYwpIiScrRrxH2yDSnIbzk6LyaxjQsO3W135dUNat+2UNmd4PCvptMvlmek4HkoVTtP6m7QLw== X-Microsoft-Exchange-Diagnostics: 1;CO2PR15MB0073;6:mkrbFWPuC5Wk4/HkknHbaBUBJg2boJI6ICjEzs9980po7sT96P5+6al2SaLnPEDlALS1CJP36oRWxKP3eweibN/StDLOLiJ9sH+RtrrNh/WS7E9S8DKriFbAi4Cv/UB3/oyoo9NnHd9kQKIDx5xE7vYoy/g3WghiBsT9VbNem8AEsXEWWbXgvyvsLn2rCj3T7SXcq5Fpv68CCFPR4KRAYhdq6o6MpoSKuqEv+y50DComZSXq0VZu49swHkSxgaSYkpMYArwXKT/pvNqgNfulM0UjfGusEEFb6772u74HYLSUseHWT4TiIBx65pE1ZYT5yrAn7/1aU7O7IGtoDe/zao8T6ZWq0ZXgwCGcu0NbY+jjwIPuAF54vSnFSj3oaRQUBH5FDcqiFCqsBdHdOmY+eLKO+Ht5Wf7qazue+5xlFCrQa9aYXQesWDwYVBJyUDs36bnyQGMEkOb0WxpEvkicqQ==;5:JenMI5FSDTj5ktwLFO/+ceV7bg/dYWRhfzfvPrmH6mImx6i397ozEFf9z3cuntFpu7RYKx5FBM5V/kSoBzYq7eotQhAjIcPcI4jSAnyakA/G1bGQHAJXgIKj5rqKPco4SGA3cqYp4wO1B2x0jszk+C0D20nkW3jONpAOkYlb0Gk=;24:WxXFpZYpdyyxAI1xGQFsT60iHN3yTooa9Nzh8DbY/QF52mkbT1ndrt3OpSOfchZZATmkfwgdggxrLCj342qMPkYPHuJyeyM/V7IunK8DGhQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CO2PR15MB0073;7:KpkGV4OQnnuvcSrm8N0CB3T43vv8sWIl7xB07/AwSE0g00LEE9Q34ha82P+7G2A7ZCw4NAd4z0E7Ce6YHubWJpZpMIaDa3NSXxpvhpAwOKhC/tlH8bNtA+4iUhVOsXntCBg+Hyj12ngA/ORGQPmpxFXbXf41ZHHJStzQ2hC4nqXC+B4uh1ZY40f6+HbsmkdccEa7cb9xX+R7cOiLAIGiTYoWJj5xNZiz+/G04eOM2hZKyEHotQpHPvMN15f5ttKu;20:7Nmp4F9rXkORiwTlOeQ93twMYJRrINOe6PllIlNrOYz/52nNRZ5W/3hx7igvkaEiTyY/+Uj6/ZgD2HaT3RchTazaoFMEFygMo2fP/pfAXrmqYx2Up8SbN6tfVNGzRkg8DoqDjXrUshXmYpg+diMh0W5pVdzn7VPuQ/Y/V79SUr8= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2018 14:18:26.6494 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 76647586-0f6c-4793-03c4-08d5d6b8b1b7 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR15MB0073 X-OriginatorOrg: fb.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-06-20_07:,, signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-SW-Source: 2018-q2/txt/msg00245.txt.bz2 On 6/20/18 4:41 AM, Mark Wielaard wrote: > On Sat, 2018-06-16 at 13:02 -0700, Yonghong Song wrote: >> Due to libdw does not have proper BPF relocation support, >> the pahole cannot display filenames correctly for objects >> with default llvm options. So we have to invent >> a special option "llc -march=bpf -mattr=dwarfris" to >> prevent llvm from generating cross-section dwarf relocation >> records (https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_rL326505&d=DwIFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=BipW-mskUvazgUra_yLXaDDQuxRPN7odXPkQGoyQPCY&s=o2hBnG4NsHUyYJPq0YMC9vTjoTet5flJ1AnhjW8tDBw&e=). >> The pahole related discussion is in linux netdev >> mailing list (https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.openwall.net_netdev_2018_06_15_38&d=DwIFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=DA8e1B5r073vIqRrFz7MRA&m=BipW-mskUvazgUra_yLXaDDQuxRPN7odXPkQGoyQPCY&s=oqLz1O0PLduCn5Y2DVhr5yIpsLrSZ4GoRbHcZs5ZocA&e=, etc.) >> >> We would like to add proper BPF relocation support >> to libdw so eventually we could retire the special llc bpf >> flag "-mattr=dwarfris". >> >> The bpf relocations are defined in >> llvm_repo:include/llvm/BinaryFormat/ELFRelocs/BPF.def: >>   ELF_RELOC(R_BPF_NONE,        0) >>   ELF_RELOC(R_BPF_64_64,       1) >>   ELF_RELOC(R_BPF_64_32,      10) >> >> Removed the relocation type R_BPF_MAP_FD whoes name does not >> confirm to llvm definition and replaced it with R_BPF_64_64. >> The BPF object is just a relocatible object, not an executable or >> a shared library, so assign ELF type to REL only in bpf_reloc.def. >> >> Signed-off-by: Yonghong Song >> --- >>  backends/ChangeLog                  |   7 +++++ >>  backends/Makefile.am                |   2 +- >>  backends/bpf_init.c                 |   1 + >>  backends/bpf_reloc.def              |   3 +- >>  backends/bpf_symbol.c               |  54 >> ++++++++++++++++++++++++++++++++++++ >>  libelf/elf.h                        |   3 +- >>  tests/ChangeLog                     |   9 ++++++ >>  tests/Makefile.am                   |   5 +++- >>  tests/run-reloc-bpf.sh              |  33 ++++++++++++++++++++++ >>  tests/testfile-bpf-reloc.expect.bz2 | Bin 0 -> 300 bytes >>  tests/testfile-bpf-reloc.o.bz2      | Bin 0 -> 933 bytes >>  11 files changed, 113 insertions(+), 4 deletions(-) >>  create mode 100644 backends/bpf_symbol.c >>  create mode 100755 tests/run-reloc-bpf.sh >>  create mode 100644 tests/testfile-bpf-reloc.expect.bz2 >>  create mode 100644 tests/testfile-bpf-reloc.o.bz2 >> >> Note: >>  I didn't add the Changelog to libelf/elf.h as I anticipate the >>  change will come from sync'ing with glibc. >>  If this patch version looks good, I can send another revision >>  once the libelf/elf.h is synced. > > The patch looks perfect. And the new testcase is good. I used the > testfile to quickly test eu-readelf --debug-dump also got the > relocations right, and it did of course. > > Just waiting for the glibc elf.h update/sync and then I'll push this to > master. This looks perfect. Thanks! > > Thanks, > > Mark >