public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: "Frank Ch. Eigler" <fche@redhat.com>,
	"Dmitry V. Levin" <ldv@altlinux.org>
Cc: Aaron Merey <amerey@redhat.com>, elfutils-devel@sourceware.org
Subject: Re: [PATCH] Fix 'make coverage' when used with lcov version 2.0+
Date: Tue, 14 May 2024 17:39:35 +0200	[thread overview]
Message-ID: <72d358733ff3d1a5bdc2f48d8d14438f94af2ae1.camel@klomp.org> (raw)
In-Reply-To: <20240510013742.GB5939@redhat.com>

Hi,

I think things worked out in the end, so that is good.

Personally I didn't think Dmitry's request to take his review into
account was exaggerating. But that might be because I know him and am
happy with his suggestions in general.

If the tone of some request was interpreted as "not collegial and
exaggerated", then maybe next time also provide an example of how to
formulate the request that sounds better. Tone is a difficult thing,
especially on the mailinglist.

Cheers,

Mark

  reply	other threads:[~2024-05-14 15:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-06 20:45 Aaron Merey
2024-05-06 23:35 ` Dmitry V. Levin
2024-05-08 16:28 ` Aaron Merey
2024-05-09 21:53   ` Dmitry V. Levin
2024-05-09 22:08     ` Frank Ch. Eigler
2024-05-09 22:59       ` Dmitry V. Levin
2024-05-09 23:03         ` Frank Ch. Eigler
2024-05-10  0:16           ` Dmitry V. Levin
2024-05-10  1:37             ` Frank Ch. Eigler
2024-05-14 15:39               ` Mark Wielaard [this message]
2024-05-09 23:24         ` [COMMITTED] Makefile.am: Avoid code duplication Aaron Merey
2024-05-09 23:36           ` Dmitry V. Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72d358733ff3d1a5bdc2f48d8d14438f94af2ae1.camel@klomp.org \
    --to=mark@klomp.org \
    --cc=amerey@redhat.com \
    --cc=elfutils-devel@sourceware.org \
    --cc=fche@redhat.com \
    --cc=ldv@altlinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).