From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76659 invoked by alias); 29 Oct 2019 15:55:32 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 76644 invoked by uid 89); 29 Oct 2019 15:55:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:452, 2019-10-07, 20191007 X-Spam-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 Oct 2019 15:55:30 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 1B2F1302BB3C; Tue, 29 Oct 2019 16:55:28 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id E0D8E400104D; Tue, 29 Oct 2019 16:55:27 +0100 (CET) Message-ID: <75e1c6f9474614247e03c2d5bfd531e843003287.camel@klomp.org> Subject: Re: [PATCH 1/5] libdwfl: don't bother freeing frames outside of dwfl_thread_getframes From: Mark Wielaard To: Omar Sandoval , elfutils-devel@sourceware.org Date: Tue, 29 Oct 2019 15:55:00 -0000 In-Reply-To: <3781a93480de5d91ab8df92a04517654117643d8.1570438723.git.osandov@fb.com> References: <3781a93480de5d91ab8df92a04517654117643d8.1570438723.git.osandov@fb.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-5.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2019-q4/txt/msg00069.txt.bz2 Hi Omar, On Mon, 2019-10-07 at 02:05 -0700, Omar Sandoval wrote: > dwfl_thread_getframes always frees the state before returning, so > dwfl_getthreads and getthread don't need to do it. I am not sure I follow. dwfl_getthreads can be used independently from its (indirect) usage from dwfl_thread_getframes. So doesn't it need to do its own cleanup? Thanks, Mark