From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id 5A5523858D3C for ; Thu, 16 Sep 2021 10:51:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5A5523858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl [83.87.18.245]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id C0CCF3000648; Thu, 16 Sep 2021 12:50:59 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 830E4413CE02; Thu, 16 Sep 2021 12:50:59 +0200 (CEST) Message-ID: <771ec724139520df6d351ed7ea6b2ea525dbac00.camel@klomp.org> Subject: Re: [Bug debuginfod/27277] Describe retrieved files when verbose From: Mark Wielaard To: Noah Sanci Cc: elfutils-devel@sourceware.org Date: Thu, 16 Sep 2021 12:50:59 +0200 In-Reply-To: References: <20210805165402.GD4195@redhat.com> <35f2073dfeed8f008d42a78bf60b7efcf13164eb.camel@klomp.org> <20210806185459.GE4195@redhat.com> <9ac621fee207ef233873c40843b3d34ced9019cc.camel@klomp.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Sep 2021 10:51:07 -0000 Hi Noah, On Mon, 2021-09-13 at 16:07 -0400, Noah Sanci via Elfutils-devel wrote: > On Sun, Sep 12, 2021 at 3:08 PM Mark Wielaard wrote: > > > run-debuginfod-fd-prefetch-caches.sh was updated so that it doesn't > > > trip and fail as previously greping for a value that should yield zer= o > > > caused an error. > >=20 > > I think this part should be in this patch. >=20 > Do you mean should or shouldn't? Removed for now. That should should have been shouldn't. > > > +# Wait till both files are in the index and scan/index fully > > > finished > > > +wait_ready $PORT1 'thread_work_total{role=3D"traverse"}' 2 > > > +wait_ready $PORT1 'thread_work_pending{role=3D"scan"}' 0 > > > +wait_ready $PORT1 'thread_busy{role=3D"scan"}' 0 > > > +# All rpms need to be in the index, except the dummy permission- > > > 000 one > > > +rpms=3D$(find R -name \*rpm | grep -v nothing | wc -l) > > > +wait_ready $PORT1 'scanned_files_total{source=3D".rpm archive"}' > > > $rpms > > > +kill -USR1 $PID1 # two hits of SIGUSR1 may be needed to resolve > > > .debug->dwz->srefs > > > +# Wait till both files are in the index and scan/index fully > > > finished > > > +wait_ready $PORT1 'thread_work_total{role=3D"traverse"}' 3 > > > +wait_ready $PORT1 'thread_work_pending{role=3D"scan"}' 0 > > > +wait_ready $PORT1 'thread_busy{role=3D"scan"}' 0 > >=20 > > Is it really necessary to add all this if this is just a test to > > check > > the new headers are sent? >=20 > A lot of the setup is to check that both the archive and regular file > headers are added. In the attached > path I removed as much as I felt reasonable. Please get back to me on > if it is enough. Ah, yes, of course I had forgotten about the archive headers. > Subject: [PATCH] debuginfod: PR27277 - Describe retrieved files when verb= ose >=20 > Allow users, with enough verbosity, to print the HTTP response headers > upon retrieving a file. These files may include several custome http > response headers such as X-DEBUGINFOD-FILE, X-DEBUGINFOD-SIZE, and > X-DEBUGINFOD-ARCHIVE. These headers are added from the daemon, in > debuginfod.cxx. > run-debuginfod-fd-prefetch-caches.sh was updated so that it doesn't > trip and fail as previously greping for a value that should yield zero > caused an error. ^ This paragraph doesn't document a change in the patch. > E.g output: >=20 > HTTP/1.1 200 OK > Connection: Keep-Alive > Content-Length: 4095072 > Cache-Control: public > Last-Modified: Thu, 09 Sep 2021 19:06:40 GMT > X-FILE: debuginfod > X-FILE-SIZE: 4095072 > Content-Type: application/octet-stream > Date: Fri, 10 Sep 2021 16:38:06 GMT >=20 > https://sourceware.org/bugzilla/show_bug.cgi?id=3D27277 But except for that one paragraph in the commit message that shouldn't be there, this looks good. Please remove that paragraph from the commit message (or replace it with one describing the new test added), rebase it against the master branch and push it please. Thanks, Mark