From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id 2A6053844051 for ; Fri, 29 Jan 2021 20:38:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2A6053844051 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mark@klomp.org Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 3523C3000731; Fri, 29 Jan 2021 21:38:47 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id F0D2F407830E; Fri, 29 Jan 2021 21:38:46 +0100 (CET) Message-ID: <7b4ad9ddb04eb3a05d0f9062c923bd0873611fda.camel@klomp.org> Subject: Re: [PATCH 2/4] zstrptr: Pull print_string() into file scope From: Mark Wielaard To: tbaeder@redhat.com, elfutils-devel@sourceware.org Date: Fri, 29 Jan 2021 21:38:46 +0100 In-Reply-To: <20210108081328.2202283-3-tbaeder@redhat.com> References: <20210108081328.2202283-1-tbaeder@redhat.com> <20210108081328.2202283-3-tbaeder@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jan 2021 20:38:49 -0000 Hi Timm, On Fri, 2021-01-08 at 09:13 +0100, Timm B=C3=A4der via Elfutils-devel wrote= : > Get rid of a nested function this way. OK. This doesn't immediately make clear that the given scn and ndx refer to the same section. But it does test the same thing (that given section strings can be accessed through elf_strptr whether or not that section is compressed. Added a ChangeLog entry and pushed. Thanks, Mark