From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 690A5385842C for ; Fri, 5 Nov 2021 09:34:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 690A5385842C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl [83.87.18.245]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 4EB33302FBA6; Fri, 5 Nov 2021 10:34:39 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 8F541413CD45; Fri, 5 Nov 2021 10:34:38 +0100 (CET) Message-ID: <7b7217036e620e60f9da97c79cf5e98b6a1aedc8.camel@klomp.org> Subject: Re: [PATCH] (v2) read inlining info in an NVIDIA extended line map From: Mark Wielaard To: John Mellor-Crummey , elfutils-devel@sourceware.org Cc: Jonathon Anderson , Xiaozhu Meng Date: Fri, 05 Nov 2021 10:34:38 +0100 In-Reply-To: References: <7C166312-4876-444F-9B85-C7E30C8F4959@rice.edu> <37B899F3-FD5F-4F7B-9F1B-BE63CF84F554@rice.edu> <413A462A-D548-452E-9323-5193339C288A@rice.edu> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2021 09:34:43 -0000 Hi, On Thu, 2021-11-04 at 16:41 -0500, John Mellor-Crummey via Elfutils- devel wrote: > [We would really like this patch in the forthcoming release] >=20 > Attached is a new version of the patch for reading inlining > information encoded in an enhanced line map format used in NVIDIA GPU > binaries for CUDA 11.2+. It looks like the attachment is missing. Or the mailinglist removed it for some reason, but I also didn't see it here: https://sourceware.org/pipermail/elfutils-devel/2021q4/004307.html Could you resent it? Thanks, Mark > This is an updated version of a patch first submitted on Sept. 5. A > copy of the original submission email is quoted below this note.=20 >=20 > Here I describe just the improvements to that patch that address > Mark=E2=80=99s concerns: >=20 > (1) all of the code for handling NVIDIA DWARF extensions is always > available; there is no special configuration switch needed. > (2) all changes are bracketed by comments that mark them NVIDIA > extensions > (3) the DWARF extended opcodes have been renamed with names that > include NVIDIA in them > (4) the two new API functions to surface the new information have > been improved to separate the interface result from the internal > representation (at Mark=E2=80=99s request) > (4a) the API for extracting the name of an inlined function in > a DWARF line now returns a const char * instead of a string table > index > (4b) the API for extracting an inline =E2=80=9Ccontext=E2=80=9D now retu= rns a > pointer to a DWARF line where the code is inlined rather than > returning an unsigned int (an index into the line table that one > could use to compute the pointer) > (5) there are test cases for readelf and libdw that use a binary > generated by NVIDIA=E2=80=99s compiler. the test cases include informatio= n > about how the binary was generated