public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <aegon@wildebeest.org>
To: Sergei Trofimovich <slyich@gmail.com>
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH v2] tests: do not fail on zero sized DIEs (binutils-2.39 compatible)
Date: Thu, 13 Oct 2022 16:40:36 +0200	[thread overview]
Message-ID: <7d9993c1526de965d7f9b4018c6a3d4b42659259.camel@wildebeest.org> (raw)
In-Reply-To: <YvBIJe5PPbvAhKGP@wildebeest.org>

Hi,

On Mon, 2022-08-08 at 01:17 +0200, Mark Wielaard wrote:
> On Sun, Aug 07, 2022 at 07:31:38PM +0100, Sergei Trofimovich via
> Elfutils-devel wrote:
> > binutils started producing 0-sized DIEs on functions interspersed
> > by nested sections (".section ...; .previous). This led to
> > run-low_high_pc.sh failure in form of:
> > 
> >     FAIL: run-low_high_pc.sh
> >     ========================
> > 
> >     [b] main.c
> >     [2d] main
> > 
> >     [b] ../sysdeps/i386/start.S
> >     [26] _start
> >     [40] ../sysdeps/x86/abi-note.c
> >     [b52] init.c
> >     [b8e] static-reloc.c
> >     [2dba] _dl_relocate_static_pie
> >     [2dd8] ../sysdeps/i386/crti.S
> >     [2def] _init
> >     lowpc: 8049000, highpc: 8049000lx
> >     ../sysdeps/i386/crti.S: [2def] '_init' highpc <= lowpc
> >     FAIL run-low_high_pc.sh (exit status: 255)
> > 
> > To work it around let's allow lowpc == highpc special case.
> > 
> > https://sourceware.org/bugzilla/show_bug.cgi?id=29450
> 
> Thanks for finding this and suggesting a workaround.  But lets first
> try to fix binutils. This seems like a pretty bad bug, lets hope it
> gets fixed soon. So we don't need these kind of workarounds.
> 
> I added a comment to the binutils bug:
> https://sourceware.org/bugzilla/show_bug.cgi?id=29451#c2

Since this binutils bug was fixed I assume this patch isn't needed
anymore.

Thanks,

Mark

  reply	other threads:[~2022-10-13 14:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-06  8:53 [PATCH] " Sergei Trofimovich
2022-08-07 15:32 ` Martin Liška
2022-08-07 18:31 ` [PATCH v2] " Sergei Trofimovich
2022-08-07 23:17   ` Mark Wielaard
2022-10-13 14:40     ` Mark Wielaard [this message]
2022-10-13 18:13       ` Sergei Trofimovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d9993c1526de965d7f9b4018c6a3d4b42659259.camel@wildebeest.org \
    --to=aegon@wildebeest.org \
    --cc=elfutils-devel@sourceware.org \
    --cc=slyich@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).