From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id 804A93857C7D for ; Fri, 30 Oct 2020 23:57:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 804A93857C7D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mark@klomp.org Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 87D0230278CD for ; Sat, 31 Oct 2020 00:57:00 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 08B964000C89; Sat, 31 Oct 2020 00:57:00 +0100 (CET) Message-ID: <847d3f55d69e521d2d2e0319a18ae775eb8d896c.camel@klomp.org> Subject: Re: [PATCH] tests: Run valgrind also on binary tests. From: Mark Wielaard To: elfutils-devel@sourceware.org Date: Sat, 31 Oct 2020 00:56:59 +0100 In-Reply-To: <20201029172724.28643-1-mark@klomp.org> References: <20201029172724.28643-1-mark@klomp.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Oct 2020 23:57:03 -0000 On Thu, 2020-10-29 at 18:27 +0100, Mark Wielaard wrote: > When configuring with --enable-valgrind we were only running valgrind > on tests with a shell wrapper script. This patch makes sure to also > run > valgrind on "pure" binary tests. This found one small issue in libasm > where we could be writing some uninitialized padding to an ELF file. > And there were a couple tests that didn't clean up all the resources > they used. Both issues are also fixed with this patch. Pushed