From: Mark Wielaard <mark@klomp.org>
To: Ilya Leoshkevich <iii@linux.ibm.com>, elfutils-devel@sourceware.org
Subject: Re: [PATCH RFC 10/11] configure: Add --disable-demangle
Date: Wed, 08 Feb 2023 19:14:37 +0100 [thread overview]
Message-ID: <851b98fd0229e6d287e208a8816ee10b5d6488ad.camel@klomp.org> (raw)
In-Reply-To: <20230206222513.1773039-11-iii@linux.ibm.com>
Hi Ilya,
On Mon, 2023-02-06 at 23:25 +0100, Ilya Leoshkevich via Elfutils-devel
wrote:
> __cxa_demangle is normally implemented in the C++ runtime library,
> instrumenting which for MSan is a hassle. Add a knob for disabling it.
>
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
> configure.ac | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 7dc9be63..6a5c38af 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -466,11 +466,17 @@ CFLAGS="$CFLAGS -D_GNU_SOURCE"
> AC_FUNC_STRERROR_R()
> CFLAGS="$old_CFLAGS"
>
> +AC_ARG_ENABLE([demangler],
> +AS_HELP_STRING([--disable-demangle],
> + [Disable libstdc++ demangle support]))
Typo [--disable-demangler] (missing r).
Also we want to enable demangler support by default if the enable
option isn't given, so you need to add [], [enable_demangler=yes] at
the end.
AC_ARG_ENABLE (feature, help-string, [action-if-given], [action-if-not-
given])
So the action-if-not-given is to enable the feature.
Note that otherwise the summary at the end will have nothing for:
libstdc++ demangle support :
Should be either yes or no, even when --enable-demangler or --disable-
demangler isn't given.
Cheers,
Mark
> +AS_IF([test "x$enable_demangler" == xyes],
> AC_CHECK_LIB([stdc++], [__cxa_demangle], [dnl
> AC_DEFINE([USE_DEMANGLE], [1], [Defined if demangling is enabled])])
> AM_CONDITIONAL(DEMANGLE, test "x$ac_cv_lib_stdcpp___cxa_demangle" = "xyes")
> AS_IF([test "x$ac_cv_lib_stdcpp___cxa_demangle" = "xyes"],
> - [enable_demangler=yes],[enable_demangler=no])
> + [enable_demangler=yes],[enable_demangler=no]),
> +AM_CONDITIONAL(DEMANGLE, false))
>
> AC_ARG_ENABLE([textrelcheck],
> AS_HELP_STRING([--disable-textrelcheck],
next prev parent reply other threads:[~2023-02-08 18:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 22:25 [PATCH RFC 00/11] Add Memory Sanitizer support Ilya Leoshkevich
2023-02-06 22:25 ` [PATCH RFC 01/11] libdwfl: Fix debuginfod_client redefinition Ilya Leoshkevich
2023-02-07 19:22 ` Mark Wielaard
2023-02-07 19:47 ` Ilya Leoshkevich
2023-02-06 22:25 ` [PATCH RFC 02/11] libasm: Fix xdefault_pattern initialization Ilya Leoshkevich
2023-02-07 19:41 ` Mark Wielaard
2023-02-07 19:49 ` Ilya Leoshkevich
2023-02-06 22:25 ` [PATCH RFC 03/11] printversion: Fix unused variable Ilya Leoshkevich
2023-02-07 20:44 ` Mark Wielaard
2023-02-08 12:22 ` Ilya Leoshkevich
2023-02-09 14:04 ` Mark Wielaard
2023-02-09 14:57 ` Ilya Leoshkevich
2023-02-06 22:25 ` [PATCH RFC 04/11] readelf: Fix set but not used parameter Ilya Leoshkevich
2023-02-08 16:52 ` Mark Wielaard
2023-02-06 22:25 ` [PATCH RFC 05/11] readelf: Fix set but not used variable Ilya Leoshkevich
2023-02-08 17:09 ` Mark Wielaard
2023-02-06 22:25 ` [PATCH RFC 06/11] Initialize reglocs for VMCOREINFO Ilya Leoshkevich
2023-02-08 17:27 ` Mark Wielaard
2023-02-06 22:25 ` [PATCH RFC 07/11] addr2line: Do not test demangling in run-addr2line-i-test.sh Ilya Leoshkevich
2023-02-08 18:15 ` Mark Wielaard
2023-02-06 22:25 ` [PATCH RFC 08/11] x86_64_return_value_location: Support lvalue and rvalue references Ilya Leoshkevich
2023-02-06 22:25 ` [PATCH RFC 09/11] configure: Use -fno-addrsig if possible Ilya Leoshkevich
2023-02-06 22:25 ` [PATCH RFC 10/11] configure: Add --disable-demangle Ilya Leoshkevich
2023-02-08 18:14 ` Mark Wielaard [this message]
2023-02-06 22:25 ` [PATCH RFC 11/11] configure: Add --enable-sanitize-memory Ilya Leoshkevich
2023-02-07 19:05 ` [PATCH RFC 00/11] Add Memory Sanitizer support Mark Wielaard
2023-02-07 19:46 ` Ilya Leoshkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=851b98fd0229e6d287e208a8816ee10b5d6488ad.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=iii@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).