From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id 807C5393A41B for ; Mon, 3 May 2021 12:59:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 807C5393A41B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mark@klomp.org Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id F0FD8302BBED; Mon, 3 May 2021 14:59:47 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 366E9413CB92; Mon, 3 May 2021 14:59:47 +0200 (CEST) Message-ID: <85b7a4abf53bcfabba0ff7cf819c55dfcab328bf.camel@klomp.org> Subject: Re: PATCH: PR27783: debuginfod: fetch default DEBUGINFOD_URLS from systemwide file From: Mark Wielaard To: "Frank Ch. Eigler" , elfutils-devel@sourceware.org Date: Mon, 03 May 2021 14:59:47 +0200 In-Reply-To: <20210429161348.GB6131@redhat.com> References: <20210429161348.GB6131@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 May 2021 12:59:51 -0000 Hi Frank, On Thu, 2021-04-29 at 12:13 -0400, Frank Ch. Eigler via Elfutils-devel wrote: > This change was suggested by fedora fesco folks, to make it easier > for for auxiliary system daemons to use debuginfod by default. >=20 > commit 4db2eba32aaed7d567f5ebea6b2eb7a6dc4b4b36 > Author: Frank Ch. Eigler > Date: Thu Apr 29 11:49:14 2021 -0400 >=20 > PR27783 debuginfod: fetch default DEBUGINFOD_URLS from systemwide fil= e > =20 > Introduce use of a systemwide config file /etc/debuginfod_urls for a > fallback default for an unset $DEBUGINFOD_URLS. $DEBUGINFOD_URLS_FIL= E > overrides the default location of that file, which is probably mainly > useful for testing. Deprecate the similar /etc/profile.d/debuginfod* > mechanism that affected only login shells. > =20 > OTOH, setting ANY of the following to be an empty string will disable > debuginfod-client capability: > - env var $DEBUGINFOD_URLS > - env var $DEBUGINFOD_URLS_FILE > - the file named by $DEBUGINFOD_URLS_FILE So this replaces the profile environment settings with a system-wide config file. Which isn't really the same thing. Like you said it would also enable debuginfod in settings that don't have the DEBUGINFOD_URLS environment variable set, like system daemons. But I think that is the nice things about using the environment variable to indicate debuginfod-client should be used in a specific environment. If a daemon does want to use debuginfod-client it must set the environment variable explicitly. systemd provides a simple way to set environment variables, either through Environment or EnvironmentFile: http://0pointer.de/public/systemd-man/systemd.exec.html#Environment=3D Personally I think it would be better to make enablement of debuginfod- client specific for different environment (using it by default in a system daemon is different from running it standard in a login shell). Also some distros already seem to rely on the profile files, so removing them now seems like a bad idea. Cheers, Mark