From: Ben Gamari <ben@smart-cactus.org>
To: elfutils-devel@lists.fedorahosted.org
Subject: Re: [PATCH] readelf: Show set_loc argument as hexadecimal
Date: Wed, 25 Nov 2015 17:30:05 +0100 [thread overview]
Message-ID: <877fl69h4i.fsf@smart-cactus.org> (raw)
In-Reply-To: 1448468618-14285-1-git-send-email-ben@smart-cactus.org
[-- Attachment #1: Type: text/plain, Size: 767 bytes --]
Ben Gamari <ben@smart-cactus.org> writes:
> ---
> src/readelf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/readelf.c b/src/readelf.c
> index 7c3237f..e2f8fa9 100644
> --- a/src/readelf.c
> +++ b/src/readelf.c
> @@ -4973,7 +4973,7 @@ print_cfa_program (const unsigned char *readp, const unsigned char *const endp,
> goto invalid;
> op1 = read_addr_unaligned_inc (ptr_size, dbg, readp);
> op1 += vma_base;
> - printf (" set_loc %" PRIu64 "\n", op1 * code_align);
> + printf (" set_loc %" PRIx64 "\n", op1 * code_align);
> break;
On second thought, this should probably have a `0x` in front of it.
One last try coming. Sorry for the noise everyone.
Cheers,
- Ben
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]
next reply other threads:[~2015-11-25 16:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 16:30 Ben Gamari [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-02-18 13:51 Mark Wielaard
2016-02-09 22:35 Mark Wielaard
2016-01-23 20:39 Mark Wielaard
2016-01-20 23:14 Roland McGrath
2015-11-25 18:44 Josh Stone
2015-11-25 16:31 Ben Gamari
2015-11-25 16:23 Ben Gamari
2015-11-25 16:22 Ben Gamari
2015-11-25 16:21 Ben Gamari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fl69h4i.fsf@smart-cactus.org \
--to=ben@smart-cactus.org \
--cc=elfutils-devel@lists.fedorahosted.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).