public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Mark Wielaard <mark@klomp.org>
Cc: elfutils-devel@sourceware.org,
	 Panu Matilainen <pmatilai@laiskiainen.org>
Subject: Re: [PATCH] elfclassify tool
Date: Mon, 12 Aug 2019 08:14:00 -0000	[thread overview]
Message-ID: <87a7cex0kj.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <a2dd6b0becb9c886f03b66a067c0d25417e4ec16.camel@klomp.org> (Mark	Wielaard's message of "Mon, 12 Aug 2019 01:37:54 +0200")

* Mark Wielaard:

> What do you think about this change to dwelf_elf_begin?
> The change would make it possible to detect real errors in the
> elfclassify code, whether elf_begin or dwelf_elf_begin was used. So we
> would not misclassify files (but return an error status of 2).

I'm not really familiar with how these functions are used, sorry,
Viewed in isolation, the changes appear reasonable to me.

Thanks,
Florian

  reply	other threads:[~2019-08-12  8:14 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-12 15:38 Florian Weimer
2019-04-15 15:39 ` Mark Wielaard
2019-04-16 11:38   ` Florian Weimer
2019-04-18 11:17     ` Florian Weimer
2019-07-19 12:47       ` Mark Wielaard
2019-07-19 13:43         ` Dmitry V. Levin
2019-07-19 14:21           ` Mark
2019-07-19 18:35             ` Dmitry V. Levin
2019-07-19 21:00               ` Florian Weimer
2019-07-19 21:23                 ` Dmitry V. Levin
2019-07-19 21:36                   ` Mark Wielaard
2019-07-19 22:57                     ` Dmitry V. Levin
2019-07-20 21:51                       ` Mark Wielaard
2019-07-25 22:39                         ` [PATCH] elfclassify: Add --library classification Mark Wielaard
2019-07-26 22:53                           ` Dmitry V. Levin
2019-07-26 23:04                         ` [PATCH] elfclassify tool Dmitry V. Levin
2019-07-27 11:54                           ` Mark Wielaard
2019-07-20 21:40         ` Mark Wielaard
2019-07-22 15:55         ` Florian Weimer
2019-07-26 22:11           ` Mark Wielaard
2019-07-29  8:44             ` Florian Weimer
2019-07-29 14:24               ` Mark Wielaard
2019-08-11 23:38                 ` Mark Wielaard
2019-08-12  8:14                   ` Florian Weimer [this message]
2019-08-12 15:18                     ` Mark Wielaard
2019-07-29  9:16             ` Florian Weimer
2019-07-29 14:34               ` Mark Wielaard
2019-07-29 14:38                 ` Florian Weimer
2019-08-13  9:44                   ` Mark Wielaard
2019-08-13 11:42                     ` Mark Wielaard
2019-08-14 20:46                       ` [PATCH] config/elfutils.spec.in: package eu-elfclassify Dmitry V. Levin
2019-08-15  7:33                         ` Mark Wielaard
2019-07-29  9:22             ` [PATCH] elfclassify tool Florian Weimer
2019-07-29 14:40               ` Mark Wielaard
2019-07-29 14:42                 ` Florian Weimer
2019-07-19 13:24     ` Mark Wielaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a7cex0kj.fsf@oldenburg2.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=elfutils-devel@sourceware.org \
    --cc=mark@klomp.org \
    --cc=pmatilai@laiskiainen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).