From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66837 invoked by alias); 12 Aug 2019 08:14:27 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 66786 invoked by uid 89); 12 Aug 2019 08:14:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HTo:U*mark, familiar X-Spam-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Aug 2019 08:14:24 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6F86F7E429; Mon, 12 Aug 2019 08:14:23 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-116-136.ams2.redhat.com [10.36.116.136]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2A3F71001284; Mon, 12 Aug 2019 08:14:21 +0000 (UTC) From: Florian Weimer To: Mark Wielaard Cc: elfutils-devel@sourceware.org, Panu Matilainen Subject: Re: [PATCH] elfclassify tool References: <87k1fz8c9q.fsf@oldenburg2.str.redhat.com> <2e6a27c552ae5e365db54ca6b432c77c9ad5b041.camel@klomp.org> <871s22yybt.fsf@oldenburg2.str.redhat.com> <8736mfzhob.fsf@oldenburg2.str.redhat.com> <87k1cadpym.fsf@oldenburg2.str.redhat.com> <20190726221124.GA39429@wildebeest.org> <87ef296xir.fsf@oldenburg2.str.redhat.com> <20190729142419.GB2881@wildebeest.org> Date: Mon, 12 Aug 2019 08:14:00 -0000 In-Reply-To: (Mark Wielaard's message of "Mon, 12 Aug 2019 01:37:54 +0200") Message-ID: <87a7cex0kj.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 12 Aug 2019 08:14:23 +0000 (UTC) X-IsSubscribed: yes X-SW-Source: 2019-q3/txt/msg00104.txt.bz2 * Mark Wielaard: > What do you think about this change to dwelf_elf_begin? > The change would make it possible to detect real errors in the > elfclassify code, whether elf_begin or dwelf_elf_begin was used. So we > would not misclassify files (but return an error status of 2). I'm not really familiar with how these functions are used, sorry, Viewed in isolation, the changes appear reasonable to me. Thanks, Florian