From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109913 invoked by alias); 23 Nov 2017 08:39:18 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 109897 invoked by uid 89); 23 Nov 2017 08:39:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,SPF_PASS autolearn=no version=3.3.2 spammy=facilities, sooner, HTo:U*mark, wish X-Spam-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,SPF_PASS autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: ms.seketeli.net Received: from seketeli.net (HELO ms.seketeli.net) (94.23.218.202) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Nov 2017 08:39:12 +0000 Received: from localhost (torimasen.com [88.120.68.215]) by ms.seketeli.net (Postfix) with ESMTPSA id BC2912360052; Thu, 23 Nov 2017 09:39:10 +0100 (CET) Received: by localhost (Postfix, from userid 1000) id DBF985802E4; Thu, 23 Nov 2017 09:39:09 +0100 (CET) From: Dodji Seketeli To: Mark Wielaard Cc: Tom Tromey , elfutils-devel@sourceware.org Subject: Re: [PATCH] readelf: Print DIE offset in attribute reading error messages. Organization: Me, myself and I References: <1507042757-27353-1-git-send-email-mark@klomp.org> <1510842678.6966.33.camel@klomp.org> <1511259709.3112.12.camel@klomp.org> <87bmjvxwwo.fsf@tromey.com> X-Operating-System: Fedora 28 X-URL: http://www.seketeli.net/~dodji Date: Thu, 23 Nov 2017 08:39:00 -0000 In-Reply-To: <87bmjvxwwo.fsf@tromey.com> (Tom Tromey's message of "Tue, 21 Nov 2017 12:19:03 -0700") Message-ID: <87bmjtbd8y.fsf@seketeli.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2017-q4/txt/msg00070.txt.bz2 Sorry for my late reply, Tom Tromey a =C3=A9crit: >>>>>> "Mark" =3D=3D Mark Wielaard writes: > > Mark> This has been really useful to debug some DWARF format issues, but = it > Mark> could be even more useful. Since we know the attribute name and form > Mark> (or we would have generated an error earlier) add those to the error > Mark> message too. > > Thanks for doing this. Indeed, thank you or doing this. I wish I had these facilities sooner when I was tracking the cause of my issues. So no doubt this work is going to be useful. Thanks again. Cheers, --=20 Dodji