From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29719 invoked by alias); 21 Nov 2017 19:19:24 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 29704 invoked by uid 89); 21 Nov 2017 19:19:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=HX-HELO:sk:gateway, HTo:U*mark X-Spam-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Nov 2017 19:19:22 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway32.websitewelcome.com (Postfix) with ESMTP id C3F3C3560 for ; Tue, 21 Nov 2017 13:19:04 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id HE4WeMs4ttuxmHE4WehL4A; Tue, 21 Nov 2017 13:19:04 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9oUQXO7nLkdAlIGp2DkRdp78OT2f/+H4tkds1H13pRk=; b=jD29tgl4Do3+4rgMkEoXE01CY+ GkeNjgAtRRMiFArCuc/M+le0juHJEBYRbTFxADha3TBP9rHzqEHXm0XiGzsi5mUuqMlN02E5cv+5c sSq8yCcIBAjwwwgzUn7oHv4ES; Received: from 71-218-90-63.hlrn.qwest.net ([71.218.90.63]:50098 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1eHE4W-003gkU-H7; Tue, 21 Nov 2017 13:19:04 -0600 From: Tom Tromey To: Mark Wielaard Cc: elfutils-devel@sourceware.org, Tom Tromey , Dodji Seketeli Subject: Re: [PATCH] readelf: Print DIE offset in attribute reading error messages. References: <1507042757-27353-1-git-send-email-mark@klomp.org> <1510842678.6966.33.camel@klomp.org> <1511259709.3112.12.camel@klomp.org> X-Attribution: Tom Date: Tue, 21 Nov 2017 19:19:00 -0000 In-Reply-To: <1511259709.3112.12.camel@klomp.org> (Mark Wielaard's message of "Tue, 21 Nov 2017 11:21:49 +0100") Message-ID: <87bmjvxwwo.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.218.90.63 X-Source-L: No X-Exim-ID: 1eHE4W-003gkU-H7 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-218-90-63.hlrn.qwest.net (bapiya) [71.218.90.63]:50098 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2017-q4/txt/msg00067.txt.bz2 >>>>> "Mark" == Mark Wielaard writes: Mark> This has been really useful to debug some DWARF format issues, but it Mark> could be even more useful. Since we know the attribute name and form Mark> (or we would have generated an error earlier) add those to the error Mark> message too. Thanks for doing this. Does dwarflint also report the error that prompted this? I tried dwarflint on my file, but there was a lot of output and I never did track down the precise problem, so I wasn't sure... Tom