From: Jose E. Marchesi <jose.marchesi@oracle.com>
To: elfutils-devel@lists.fedorahosted.org
Subject: Re: [PATCH] elflint: Fix sh_entsize check when comparing SHT_HASH and SHT_GNU_HASH.
Date: Wed, 10 Feb 2016 06:27:01 -0800 [thread overview]
Message-ID: <87d1s4tzd6.fsf@oracle.com> (raw)
In-Reply-To: 1455024638-12222-1-git-send-email-mjw@redhat.com
[-- Attachment #1: Type: text/plain, Size: 425 bytes --]
elflint.c: In function ‘compare_hash_gnu_hash’:
elflint.c:2483:34: error: duplicated ‘if’ condition [-Werror=duplicated-cond]
else if (hash_shdr->sh_entsize == sizeof (Elf64_Word))
~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
elflint.c:2448:29: note: previously used here
if (hash_shdr->sh_entsize == sizeof (Elf32_Word))
What a nice catch! I love GCC :)
next reply other threads:[~2016-02-10 14:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 14:27 Jose E. Marchesi [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-02-15 22:48 Mark Wielaard
2016-02-09 15:24 Mark Wielaard
2016-02-09 13:30 Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1s4tzd6.fsf@oracle.com \
--to=jose.marchesi@oracle.com \
--cc=elfutils-devel@lists.fedorahosted.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).