From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25089 invoked by alias); 16 Nov 2017 09:21:46 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 24513 invoked by uid 89); 16 Nov 2017 09:21:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=HTo:D*io X-Spam-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: albireo.enyo.de Received: from albireo.enyo.de (HELO albireo.enyo.de) (5.158.152.32) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Nov 2017 09:21:44 +0000 Received: from [172.17.203.2] (helo=deneb.enyo.de) by albireo.enyo.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1eFGMg-0002pP-53; Thu, 16 Nov 2017 09:21:42 +0000 Received: from fw by deneb.enyo.de with local (Exim 4.89) (envelope-from ) id 1eFGMf-0002ZN-VN; Thu, 16 Nov 2017 10:21:41 +0100 From: Florian Weimer To: Ulf Hermann Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH] Add replacement endian.h and byteswap.h to libgnu References: <13571bb4-a75a-070f-3d19-2da85637db23@qt.io> <87k1yq1vj3.fsf@mid.deneb.enyo.de> <021350f6-78df-9a10-cf36-b06ad119647e@qt.io> Date: Thu, 16 Nov 2017 09:21:00 -0000 In-Reply-To: <021350f6-78df-9a10-cf36-b06ad119647e@qt.io> (Ulf Hermann's message of "Thu, 16 Nov 2017 09:54:16 +0100") Message-ID: <87fu9e1suy.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-q4/txt/msg00046.txt.bz2 * Ulf Hermann: >>> Some systems don't provide endian.h and byteswap.h. The required >>> functions are trivial to define using sys/param.h and gcc builtins, >>> though. >>> >>> Also, include endian.h in dwelf_scn_gnu_compressed_size.c as that uses >>> be64toh(). >> >> This is still an issue with non-glibc, non-BSD compilation. The patch >> is not ideal, as it depends on a GCC extension, but it's an >> improvement for those who use GCC on a platform which does not provide >> these functions as part of the C library. > > Well, there are a lot of other issues to be fixed if you want to build > elfutils on anything non-gcc. We could add a further check for those > builtins and sys/param.h and then add a somewhat less trivial version > of endian.h and byteswap.h if they are missing. But that would likely > involve other compiler extensions or OS-specific headers. Ah, fair enough. I mainly wanted to increase awareness of the patch because it has not been merged yet.