public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: "Jose E. Marchesi" <jemarch@gnu.org>
To: Mark Wielaard <mark@klomp.org>
Cc: elfutils-devel@sourceware.org,  Sam James <sam@gentoo.org>
Subject: Re: [PATCH] backends: sparc uses NONE relocation type in ET_EXEC and ET_DYN files
Date: Thu, 19 Jan 2023 23:17:13 +0100	[thread overview]
Message-ID: <87k01icgpi.fsf@gnu.org> (raw)
In-Reply-To: <20230119221138.291056-1-mark@klomp.org> (Mark Wielaard's message of "Thu, 19 Jan 2023 23:11:38 +0100")


> Using the NONE relocation doesn't do anything, but is harmless.
>
> This fixes several (self) tests on sparc that use elflint to
> check files are valid ELF.

FWIW looks good to me.

>
> Signed-off-by: Mark Wielaard <mark@klomp.org>
> ---
>  backends/ChangeLog       | 4 ++++
>  backends/sparc_reloc.def | 2 +-
>  2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/backends/ChangeLog b/backends/ChangeLog
> index f28ab89b..40ec7c0c 100644
> --- a/backends/ChangeLog
> +++ b/backends/ChangeLog
> @@ -1,3 +1,7 @@
> +2023-01-19  Mark Wielaard  <mark@klomp.org>
> +
> +	* sparc_reloc.def (NONE): Add EXEC and DYN.
> +
>  2022-12-21  Shahab Vahedi  <shahab@synopsys.email>
>  
>  	* Makefile.am (modules): Add arc.
> diff --git a/backends/sparc_reloc.def b/backends/sparc_reloc.def
> index 7cd5ce96..f0eeb5c6 100644
> --- a/backends/sparc_reloc.def
> +++ b/backends/sparc_reloc.def
> @@ -28,7 +28,7 @@
>  
>  /* 	    NAME,		REL|EXEC|DYN	*/
>  
> -RELOC_TYPE (NONE,               REL)
> +RELOC_TYPE (NONE,               REL|EXEC|DYN)
>  RELOC_TYPE (8,                  REL)
>  RELOC_TYPE (16,                 REL)
>  RELOC_TYPE (32,                 REL|DYN)

  reply	other threads:[~2023-01-19 22:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-19 22:11 Mark Wielaard
2023-01-19 22:17 ` Jose E. Marchesi [this message]
2023-01-19 22:44   ` Mark Wielaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k01icgpi.fsf@gnu.org \
    --to=jemarch@gnu.org \
    --cc=elfutils-devel@sourceware.org \
    --cc=mark@klomp.org \
    --cc=sam@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).