From: Florian Weimer <fweimer@redhat.com>
To: Mark Wielaard <mark@klomp.org>
Cc: elfutils-devel@sourceware.org,
Panu Matilainen <pmatilai@laiskiainen.org>
Subject: Re: [PATCH] elfclassify tool
Date: Mon, 22 Jul 2019 15:55:00 -0000 [thread overview]
Message-ID: <87k1cadpym.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <ce73f5ebf076570ddc0c1dcd57a07ec39b7555b0.camel@klomp.org>
* Mark Wielaard:
> On Thu, 2019-04-18 at 13:17 +0200, Florian Weimer wrote:
>> * Florian Weimer:
>>
>> > > BTW. Florian, the extra options are certainly not required for you to
>> > > implement to get eu-elfclassify accepted. They are just suggestions,
>> > > which we might decide not to do/add. Or they can be added by others if
>> > > they think they are useful.
>> >
>> > Understood. I would rather fix the command line syntax as a priority,
>> > implement --unstripped, and add a test suite.
>>
>> The patch below, also available here:
>>
>> <https://pagure.io/fweimer/elfutils/commits/elfclassify>
>>
>> reworks the command line parser, implements filtering of file lists, and
>> adds the --unstripped option.
>
> That looks really good. I went ahead an fixed a couple of nits and
> added some of my suggestions. I'll respond to your other email
> explaining some of my reasoning. The changes I made are:
Wow, this is much more than I expected. Thanks!
> elfclassify: Fix bre -> be typo in "unstripped" option help text.
> elfclassify: When reading stdin make sure paths don't include newline.
> elfclassify: Allow inspecting compressed or (kernel) image files with -z.
> elfclassify: Always clean up ELF file and descriptor if one is still open.
> elfclassify: Don't treat errors in elf_open or run_classify as fatal.
> elfclassify: Add --quiet/-q to suppress error messages.
> elfclassify: Add \n to fputs debug output.
> elfclassify: Add --file/-f for testing just regular files.
> elfclassify: Require --elf by default. Add more classifications.
> elfclassify: Add elf_kind and elf_type strings for verbose output.
> elfclassify: Require PT_LOAD for loadable classification.
> elfclassify: Add --program classification.
> elfclassify: Don't use ARGP_NO_EXIT and document exit code expectation.
> elfclassify: Add --linux-kernel-module classification.
> elfclassify: Add --debug-only classification.
I went through these patches, albeit in a somewhat cursory fashion, and
they look okay to me.
Do you think this is enough to port over RPM's find-debuginfo.sh?
Thanks,
Florian
next prev parent reply other threads:[~2019-07-22 15:55 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 15:38 Florian Weimer
2019-04-15 15:39 ` Mark Wielaard
2019-04-16 11:38 ` Florian Weimer
2019-04-18 11:17 ` Florian Weimer
2019-07-19 12:47 ` Mark Wielaard
2019-07-19 13:43 ` Dmitry V. Levin
2019-07-19 14:21 ` Mark
2019-07-19 18:35 ` Dmitry V. Levin
2019-07-19 21:00 ` Florian Weimer
2019-07-19 21:23 ` Dmitry V. Levin
2019-07-19 21:36 ` Mark Wielaard
2019-07-19 22:57 ` Dmitry V. Levin
2019-07-20 21:51 ` Mark Wielaard
2019-07-25 22:39 ` [PATCH] elfclassify: Add --library classification Mark Wielaard
2019-07-26 22:53 ` Dmitry V. Levin
2019-07-26 23:04 ` [PATCH] elfclassify tool Dmitry V. Levin
2019-07-27 11:54 ` Mark Wielaard
2019-07-20 21:40 ` Mark Wielaard
2019-07-22 15:55 ` Florian Weimer [this message]
2019-07-26 22:11 ` Mark Wielaard
2019-07-29 8:44 ` Florian Weimer
2019-07-29 14:24 ` Mark Wielaard
2019-08-11 23:38 ` Mark Wielaard
2019-08-12 8:14 ` Florian Weimer
2019-08-12 15:18 ` Mark Wielaard
2019-07-29 9:16 ` Florian Weimer
2019-07-29 14:34 ` Mark Wielaard
2019-07-29 14:38 ` Florian Weimer
2019-08-13 9:44 ` Mark Wielaard
2019-08-13 11:42 ` Mark Wielaard
2019-08-14 20:46 ` [PATCH] config/elfutils.spec.in: package eu-elfclassify Dmitry V. Levin
2019-08-15 7:33 ` Mark Wielaard
2019-07-29 9:22 ` [PATCH] elfclassify tool Florian Weimer
2019-07-29 14:40 ` Mark Wielaard
2019-07-29 14:42 ` Florian Weimer
2019-07-19 13:24 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1cadpym.fsf@oldenburg2.str.redhat.com \
--to=fweimer@redhat.com \
--cc=elfutils-devel@sourceware.org \
--cc=mark@klomp.org \
--cc=pmatilai@laiskiainen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).