From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50793 invoked by alias); 22 Jul 2019 15:55:02 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 50774 invoked by uid 89); 22 Jul 2019 15:55:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=filtering, bre X-Spam-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 22 Jul 2019 15:55:00 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6D00C308FC22; Mon, 22 Jul 2019 15:54:59 +0000 (UTC) Received: from oldenburg2.str.redhat.com (dhcp-192-200.str.redhat.com [10.33.192.200]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9135D10190A2; Mon, 22 Jul 2019 15:54:58 +0000 (UTC) From: Florian Weimer To: Mark Wielaard Cc: elfutils-devel@sourceware.org, Panu Matilainen Subject: Re: [PATCH] elfclassify tool References: <87k1fz8c9q.fsf@oldenburg2.str.redhat.com> <2e6a27c552ae5e365db54ca6b432c77c9ad5b041.camel@klomp.org> <871s22yybt.fsf@oldenburg2.str.redhat.com> <8736mfzhob.fsf@oldenburg2.str.redhat.com> Date: Mon, 22 Jul 2019 15:55:00 -0000 Message-ID: <87k1cadpym.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Mon, 22 Jul 2019 15:54:59 +0000 (UTC) X-IsSubscribed: yes X-SW-Source: 2019-q3/txt/msg00073.txt.bz2 * Mark Wielaard: > On Thu, 2019-04-18 at 13:17 +0200, Florian Weimer wrote: >> * Florian Weimer: >> >> > > BTW. Florian, the extra options are certainly not required for you to >> > > implement to get eu-elfclassify accepted. They are just suggestions, >> > > which we might decide not to do/add. Or they can be added by others if >> > > they think they are useful. >> > >> > Understood. I would rather fix the command line syntax as a priority, >> > implement --unstripped, and add a test suite. >> >> The patch below, also available here: >> >> >> >> reworks the command line parser, implements filtering of file lists, and >> adds the --unstripped option. > > That looks really good. I went ahead an fixed a couple of nits and > added some of my suggestions. I'll respond to your other email > explaining some of my reasoning. The changes I made are: Wow, this is much more than I expected. Thanks! > elfclassify: Fix bre -> be typo in "unstripped" option help text. > elfclassify: When reading stdin make sure paths don't include newline. > elfclassify: Allow inspecting compressed or (kernel) image files with -z. > elfclassify: Always clean up ELF file and descriptor if one is still open. > elfclassify: Don't treat errors in elf_open or run_classify as fatal. > elfclassify: Add --quiet/-q to suppress error messages. > elfclassify: Add \n to fputs debug output. > elfclassify: Add --file/-f for testing just regular files. > elfclassify: Require --elf by default. Add more classifications. > elfclassify: Add elf_kind and elf_type strings for verbose output. > elfclassify: Require PT_LOAD for loadable classification. > elfclassify: Add --program classification. > elfclassify: Don't use ARGP_NO_EXIT and document exit code expectation. > elfclassify: Add --linux-kernel-module classification. > elfclassify: Add --debug-only classification. I went through these patches, albeit in a somewhat cursory fashion, and they look okay to me. Do you think this is enough to port over RPM's find-debuginfo.sh? Thanks, Florian