From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by sourceware.org (Postfix) with ESMTPS id C61663857405 for ; Thu, 26 Aug 2021 12:00:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C61663857405 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: aratiu) with ESMTPSA id C42E01F43501 From: Adrian Ratiu To: Mark Wielaard Cc: elfutils-devel@sourceware.org, manojgupta@chromium.org Subject: Re: [PATCH] configure.ac: drop unnecessary gnu99 extension checks In-Reply-To: References: <20210810125651.3075622-1-adrian.ratiu@collabora.com> Date: Thu, 26 Aug 2021 15:00:50 +0300 Message-ID: <87r1ege7pp.fsf@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Aug 2021 12:01:05 -0000 Hi Mark, On Mon, 23 Aug 2021, Mark Wielaard wrote: > Hi Adrian, > > On Tue, Aug 10, 2021 at 03:56:51PM +0300, Adrian Ratiu via > Elfutils-devel wrote: >> So in the interest of enabling Clang builds we remove the only >> remaining blocker: the configure checks for nested functions >> and variable length arrays which are also unused. > > Can we just remove the whole configure test? And change the > AC_PROG_CC to AC_PROG_CC_C99? Yes, I think we can do that. > > The patch doesn't update the comments about what is being > tested, and the only thing being tested now is Mixed > Declarations and Code, which is a standard part of C99. Good catch. I'll update and send a v2. > > Have you tried running make check with an alternative compiler? > There are a couple of "self tests" which run the code on the > just produced binaries and it would be interesting to know > whether or not all tests pass. I did comparative builds within the Gentoo/ChromeOS build environments with the GNU/GCC 10.2 and LLVM/Clang 13.0 toolchains. With GCC: # TOTAL: 224 PASS: 214 SKIP: 7 XFAIL: 0 FAIL: 3 XPASS: 0 ERROR: # 0 With Clang: # TOTAL: 224 PASS: 212 SKIP: 7 XFAIL: 0 FAIL: 5 XPASS: 0 ERROR: # 0 The two tests which failed are run-strip-strmerge.sh and run-reverse-sections-self.sh because the `.gnu.version` is invalid. Links are below for the gcc [1] vs clang [2] test-suite.logs. [1] https://drive.google.com/file/d/1uQSHarIQwA07fIih0ZHHt8zfim_BWRYP/view?usp=sharing [2] https://drive.google.com/file/d/1q7iGXjutyoLgM4iOm_rFMVxT11dnwpt5/view?usp=sharing Thanks, Adrian > > Thanks, > > Mark