From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70209 invoked by alias); 19 Jul 2019 21:00:55 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 70178 invoked by uid 89); 19 Jul 2019 21:00:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-Spam-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 Jul 2019 21:00:54 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CFB9CC0A4F7C; Fri, 19 Jul 2019 21:00:52 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-116-41.ams2.redhat.com [10.36.116.41]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 71960619AA; Fri, 19 Jul 2019 21:00:51 +0000 (UTC) From: Florian Weimer To: "Dmitry V. Levin" Cc: Mark Wielaard , elfutils-devel@sourceware.org, Panu Matilainen Subject: Re: [PATCH] elfclassify tool References: <87k1fz8c9q.fsf@oldenburg2.str.redhat.com> <2e6a27c552ae5e365db54ca6b432c77c9ad5b041.camel@klomp.org> <871s22yybt.fsf@oldenburg2.str.redhat.com> <8736mfzhob.fsf@oldenburg2.str.redhat.com> <20190719134341.GA26346@altlinux.org> <84da918d32c57e6f16fbcf1c854b375111dbdcb5.camel@wildebeest.org> <20190719183542.GB29323@altlinux.org> Date: Fri, 19 Jul 2019 21:00:00 -0000 In-Reply-To: <20190719183542.GB29323@altlinux.org> (Dmitry V. Levin's message of "Fri, 19 Jul 2019 21:35:43 +0300") Message-ID: <87v9vxivsu.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 19 Jul 2019 21:00:53 +0000 (UTC) X-IsSubscribed: yes X-SW-Source: 2019-q3/txt/msg00067.txt.bz2 * Dmitry V. Levin: >> So, I don't think the code is wrong. We might want to tweak the comment >> a bit though, to make it less definitive? > > What I'm saying is that has_soname is just a hint which is probably even > less reliable than has_program_interpreter. If I recall correctly, I added the soname check to classify /lib64/libc.so.6 as a library, not an executable. So it didn't come completely out of nowhere. Thanks, Florian