From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 51EA43858D33 for ; Thu, 16 Feb 2023 17:02:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 51EA43858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676566973; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lUFpDi6nVWq52H/OgGkCeR522zEJOg5RA09/glCnd3s=; b=SE9re1Z9dP01xH0xA9T2kecWPDR/rgNZy+8j2bI5ojbTGqNJ/zFt0KewHApRIERPRtzrAW qExIlJ5iJkzq6GTjvL4he/H3gN96EVuzBBM/5bMBTBqOE/BnNAeESiFz6gy3pP9ETGcS8P Knn6oNGjeSqkVacdu9UuV5hapHDeV/U= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-98-JxBdVTy3P1aXSuhtn9CsMA-1; Thu, 16 Feb 2023 12:02:52 -0500 X-MC-Unique: JxBdVTy3P1aXSuhtn9CsMA-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4708A1C08793; Thu, 16 Feb 2023 17:02:52 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6FCB8492B0E; Thu, 16 Feb 2023 17:02:51 +0000 (UTC) From: Florian Weimer To: Mark Wielaard Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH] configure: Error when demangler is enabled, but libstdc++ support isn't References: <20230215160030.45630-1-mark@klomp.org> <87o7ptrimz.fsf@oldenburg.str.redhat.com> <188c194df1b722440dd6f8757390b26a42a94cfa.camel@klomp.org> Date: Thu, 16 Feb 2023 18:02:49 +0100 In-Reply-To: <188c194df1b722440dd6f8757390b26a42a94cfa.camel@klomp.org> (Mark Wielaard's message of "Thu, 16 Feb 2023 14:08:03 +0100") Message-ID: <87wn4hpmpy.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Mark Wielaard: > Hi Florian, > > On Thu, 2023-02-16 at 11:48 +0100, Florian Weimer via Elfutils-devel > wrote: >> * Mark Wielaard: >>=20 >> > + [AC_MSG_ERROR([__cxa_demangle not found in libstdc++ use --disa= ble-demangler to disable demangler support.])]), >>=20 >> Missing punctuation after libstdc++? > > You probably mean you like to see a comma after libstdc++? Comma or semicolon. > That sounds reasonable. But I had to double quote the argument to > AC_MSG_ERROR, otherwise the comma was seen as a argument separator? Ohh. I had not consider that. > Which I find slightly odd, but I don't fully grok autoconf quotes. > > Does the following do what you expect? Yes, but even though I patched dozens of m4 files lately, I still don't get the quoting rules. For me, it's mostly =E2=80=9Cadd [=E2=80=A6] until = it breaks, then remove one layer=E2=80=9D =E2=80=A6 Thanks, Florian