From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92746 invoked by alias); 14 Dec 2017 13:55:50 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 92735 invoked by uid 89); 14 Dec 2017 13:55:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=HTo:U*mark X-Spam-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: EUR02-AM5-obe.outbound.protection.outlook.com Received: from mail-eopbgr00123.outbound.protection.outlook.com (HELO EUR02-AM5-obe.outbound.protection.outlook.com) (40.107.0.123) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Dec 2017 13:55:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qtcompany.onmicrosoft.com; s=selector1-qt-io; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=3c+du3MpRFF62JnEWW9djQUpvxIK3i8kTFLBHuzKXU8=; b=Un53fBdd5WVWlrqGLrZ3c6YUKbkyzKVNSlVdmC4vBwoz4oyEzlxMPIUEV7F1OACsBO4cfsjEhCRw2V53BHaS7sFKs1HORk94FeV34ybB6jATbEFJUrWYqQEloqAFQVlhFWAcDcVs+hYWWR2abyyjrw+2u0kQTx/QY1EZlLAUMHk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ulf.hermann@qt.io; Received: from [10.9.78.45] (62.220.2.194) by VI1PR0201MB1839.eurprd02.prod.outlook.com (2603:10a6:800:10::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Thu, 14 Dec 2017 13:55:43 +0000 Subject: Re: [PATCH 1/2 v2] Don't overflow in __libdw_in_section To: Mark Wielaard , elfutils-devel@sourceware.org References: <5ae489eb-3981-24b4-294a-734b1c52731d@qt.io> <1513259021.15696.80.camel@klomp.org> From: Ulf Hermann Message-ID: <8b4e21a8-6328-5f05-664c-004d92461ed1@qt.io> Date: Thu, 14 Dec 2017 13:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1513259021.15696.80.camel@klomp.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [62.220.2.194] X-ClientProxiedBy: HE1PR0402CA0041.eurprd04.prod.outlook.com (2603:10a6:7:7c::30) To VI1PR0201MB1839.eurprd02.prod.outlook.com (2603:10a6:800:10::13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7582b795-3c47-4db8-fb64-08d542fa5eca X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603307);SRVR:VI1PR0201MB1839; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0201MB1839;3:DThzfcU4vTBjxfLy2vccmMUSB5Kg/eOelPoimoEaofiOgQ3t321wSt7d6Ehz4CQp0FhGRuXkNLt7x8yMQ8mhFO8zjHX7Ayzsd+9oNYGKoGyBIN+DZQ+vSd9hqO/w+JP2bGUSGXrhsUgG2FzWpLfa5rN+pr54DgBvriYsGlL0yIHGW3TVq0dh7f5qv/O4zhoUaTckpkihJ2xMviIhUpAape5EDMXQnp1qzSKWFJOGb/sq7uHUbXt6S3LSivpiOFEF;25:onSnSq3B+eP3PNS1PgsFahTXNJlpiKd/JqQRXqh6eg/btNDv2W17Z/Sl6E5XhLoGflEMjuN4BPKAhIt8F2F+wygIwmW7MI6xMbQRWZhs5dIacmu12VS5oqE1O3rK3aSkoxH7PzfVQPqF7E+8ORGpaJKYTlY9S1++0wSSyK1zWXDfIbOu3UBAHv8f9OU/O9t5gyuHINy5has9lh7YeVaWMQIvA97gCHIT602p8MC/k9pXHFwmBnnlsN4JLCmt5NGqoRBm1Fh1xWjBzCqqiTKGnej/4KJKwAGKc4P4a2lM1vepI/ICL4x+HVC9PGz0WBz6QCyMNS//lzV8doKnwzUSlg==;31:LGecpoJZNTip/UmD6TYIP7Mozy5Fjsir47E9iiVsByji1WWghiZi+4KL8eghVBcwkSYSpBT0ExnyysdodfPDEaLafc7jseNej27A76BghmYOyk6Yhqv+VIRmaZ91pnrsCQl1eBttLsEoM756g+PqZCm5KyvTHz1+y6lv30zs043K3L7bMA8upbhoJJVbSf06zKYbOi4aNYL5eHHRkzRlKdhMmGv2kNi5jEQwzaCvS/I= X-MS-TrafficTypeDiagnostic: VI1PR0201MB1839: X-Microsoft-Exchange-Diagnostics: 1;VI1PR0201MB1839;20:vGcy5b+oZyktoaTHSVwfLTv1LrQwaLvnJxFWdhCkWbZJkNDRJk1pz8MUVxS2Yq69kN8jANMkTikoEUGT737NFu3PWlRU+fH6FtyrUdfkiinFnj/RTBwes1Xt9Bkv+09Gq2zQgsfUQHEim1HiyH+bGQ8yyWFI1gpV2wV8TNWYvrSRK7JvnhkYWokzIIn/Te0jR7znkD4Hu5J/GFvdL2Qu67kSIvXvr3yAdI1yVyPH3+p+25cp0mcNMElf5FE/jKomuTWjgPrNhlhRoJAbf8JspQkht1bJoDMFivl0GliYmGFVS3SzdYWviAuabjCgG2/yBcPZcKJVMmqKzdk0c3TUUqD9P4URz2QCWkUrQl9IOk1XNl5G0wG4GQNKJ7n6WLVMx1+9BQniyjYwz+h6+pUOrraHZ7Z6PR+YK9Dd7QqU3S8dStaRVX8HT8TMrUkdFZAKR7WKBkqH4CTevIQefZgolrlc1rPoCJKa4bPHZtKgVHtKQTch4eRWaZJrOQIxesWg;4:PqH7JwCgiVtTgyzHBOJEeUHww0DIycgkGHYXyXRNoRFAHGU2MI2uTrvo8lDS/L+KLqtcOb65qR3PEWGmc+rXHZmKVVBstginUOd8LH2I9qGOKBnq8VjOd0Q0O+7FgRBvkAUM6/l3dGdBzRlYsFIkE3Usx8anJtB8oQ5QK0Dt3grgGhi9MFy41Ttuu9X0HQ3FPICpprsNo8bohFRl3jaTc/HZgBXGVjzpGs1XnnrYd29/W91CDVAosYRgIgwJJfGKChJ1LTctUbHEboNxEz6+hw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(3231023)(10201501046)(6041248)(20161123564025)(20161123560025)(20161123555025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6072148)(201708071742011);SRVR:VI1PR0201MB1839;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:VI1PR0201MB1839; X-Forefront-PRVS: 05214FD68E X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6049001)(366004)(39840400004)(396003)(346002)(376002)(24454002)(189003)(199004)(65956001)(23676004)(16526018)(5660300001)(66066001)(386003)(83506002)(33896004)(52116002)(229853002)(65806001)(68736007)(65826007)(97736004)(106356001)(105586002)(25786009)(76176011)(31696002)(52146003)(2486003)(2950100002)(2906002)(230700001)(86362001)(81166006)(81156014)(8676002)(31686004)(6116002)(3846002)(6486002)(53936002)(74482002)(47776003)(36756003)(7736002)(305945005)(50466002)(64126003)(6246003)(58126008)(478600001)(316002)(53546011)(16576012)(77096006)(8936002);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR0201MB1839;H:[10.9.78.45];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: qt.io does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjAyMDFNQjE4Mzk7MjM6ZjhSWExwcVRrUGtkWE5QRHQrOXl2dGkx?= =?utf-8?B?OW5aUk14NlV6NWg2dk1PY3o0b2F0UjYwUmtrYzM2VVF0TC9aSXZLb1JYTnBQ?= =?utf-8?B?aXhvM05Bck9hckpZOUZkOEkzWGlSWWRMa2dFemMwU0dMQmI4NVlTOExPVTNO?= =?utf-8?B?OFJBVzBkVjhOOG1PRXhvc0FLaURlamw2RjZneVZoMEVmSmYzKy95ZkxrY1Zx?= =?utf-8?B?d29UTDkyVHpuMFJWTGpHa1l6ZXBXSFBtRmN2RytIYXlpaTNRVC9MNndERk1u?= =?utf-8?B?emh4U250czdiVHVYaXNRRFhRRUF1QXpSLzBhQmVVSnBBcWhQQmFQcHJUc3NL?= =?utf-8?B?SUdaL3IxTmxqR2dGVVhZbHZtd0FkWEZNTFBiWkhJNHREVk5OdVI1UDhodEU3?= =?utf-8?B?ejVVWHhCR3hsWG5OOGdIQjNsZkRvVEVMMDRNQVYwdEVDOVJYcEsrK1dldUox?= =?utf-8?B?YkRBbVNKMkhMMFptaGcwM3FtUnowa0s3bllVVU9rdS8yZUhWaVVQYVBnMUhv?= =?utf-8?B?akxXbnpiQ0pVSjVLWVlLanQzNW9QUm51U0FPZVl6TUhuTDdQOEZ4U28zZnhV?= =?utf-8?B?T01WMlhkang1M250TlNvdlhYWjdwS3FYTDZ6b3o4Y3JLNCsxcmFsVm5wSzlN?= =?utf-8?B?U2k1RUtuVEU1OHJ3cWJWU09FYkpjS0NTUEZ5d0I5L0VnaVZ0T3htNHdyaWhQ?= =?utf-8?B?NVlrczA4bWJyZllxWDlHNk9BblhEeXh0elVDZWcwVnVBSWJ4YnpZMUZhbjNR?= =?utf-8?B?R1YvYW9oaXQ2SWFDdVpNQm9kS1Zha1gvZ0tpVXFYU1FVNlJyc3RCZWVLS2lo?= =?utf-8?B?eW11eklaMUE5ZERucjhlOGFhbHBuZTdONXp6N1ZOY1RMTjYvM096VExyVHVl?= =?utf-8?B?eEJRMFd4eDZDVnkxeFdVRWkwRFNHV2huSmxhb2pocHNnOVBUMDE2UXZrbTEw?= =?utf-8?B?N3R6TXpOMDFXUFV3SGU0Y0xvWEIwVVZWM3JwdHA5WmtTcXduZGNuQklqTWxI?= =?utf-8?B?a3BEcUlvQ1p6bzVBaTBzRXJYWUhQZ3NWNzg2cU82S2FxMFRmQlVVOGdZbmMx?= =?utf-8?B?TzlJNkZLM0lnSFllZnFuNXhmUlBYOFBYSk45ZHFqWlZzYTErSXVGQTFVc2xj?= =?utf-8?B?RVJCZDQyYThVdEc0ZitYSWUxcFhmV2VXZ21uaVowTUhWMjlUV25nZ3M0dldl?= =?utf-8?B?UzRFM3BOMzVla0FHQ2s5RFRjMkR6OXR6Qm9HS1U5bG5ZcUp6M3Y2Q0RjSmdM?= =?utf-8?B?RDI5VnJUaGxiV3lHRUtmV2NlWDAySjJJODVXRDNrUGlLVWZ1Rm5lbFc0aVRt?= =?utf-8?B?VXZjdmJKRFJmYUdpZlVZLy84QU9KZGM1ZktaRDY0YnAzMkF1N2E2bW10TmZt?= =?utf-8?B?QUFObzRjWHBOYXNUZzBJWEsxUHN5aDJCbkhXUEhyak5jQ0RWc0swWnVneGpq?= =?utf-8?B?UHpsUVdMZ2NaQndGNGhJdlZzeGx4aFhIazJZVVFjRWFTWVgrR0M2MjhVbXNW?= =?utf-8?B?K0NjV1c2ZW9mRHR6bFF0VlR6NE5rZ2J5L05HRnRBVTVYWGhLeXVRU05NQURQ?= =?utf-8?B?L2xLLzlkQm1OenIwNU5EY2pNdklFVVducWJndkk1STRYcUpBWFhSbTByajEz?= =?utf-8?B?ZVpsNE1nbXZRcWRZMHNIOU5zbkttNGdWeG9kNmU5bmlpYlpaK1BLQ2lsY0Rw?= =?utf-8?B?ZWMybWVmWUhJVURoSkZVR3lWY0RkckhrV2dPMkZhZ3FrcmlobktQbU5yUWYy?= =?utf-8?Q?28HlWud7ti2StDMBmUYdOF1C1fXzKXBbGJggRQo=3D?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0201MB1839;6:WfwBBwyFYUQLiI/o61axs9jcoQ3Xy/h3QQNDeCH9X8y7ptNSajgF/JW70/fKcNHpHTgVKMR7dQsXxIHktT9q/iGh7Y/evp810o1s3u6Ci/e3VPeqv8991vEjKIRBmBjutfyhUyjvm3Z6et3/lgNlBpIO29nltBMb3fuk9LYJcCPvve+FuMBUwOSsQXZ3F92SQxtezr2a+dPRHF6U4RviVKG8cr2ErzUXFTXXgmkOOyFNjjbP8dZkVDCAECcSANWBxggYIuCdXQvxvfE/+4kWF4rhsbGXbuGGQb7vXYOABkgOHYD2LjIxPwvvaLIBgJ9LCVtAl3ujw77b4WAPVCt1AIGVDFPuyYk8SyZw9ReyKd8=;5:ixAr/SXbMy3VX0sIIaCzyS5SyUhK6YwJXDTqSSIevzc3ajkSMub5PJtgEOCp0oVYHAwJzTHkcRtyr3biKZXTkdBgn2tPM8zj/LBwC3g6R0H8JsARrqQeGa8fWsprjHogZbbRRhby7nl5kEz50wNmzWndNtf009LLYMTiDxzMTNw=;24:9jY7GH9hV1tBK+FOYRE/Eh/VuCus5DUrfLHFbd5VPqtaFhDmhhGnC2JpBzSxggKmWcz5POC1M1kU6Y5MFO8cH4gm7fhr6Q3M/qGcEPypJ28=;7:fHsHRPm++vxhFi3IBdUedhFnvOWKViXKRQ32j+/+KRj603kPaxQge5L0QMzQvxDO0X1FS9OWbob+Cfc7fNtLubf4WHwaYWqe/zW9VncV0kBiYhCHmwSfsgXE5hdpKGQi801eSrorhrG0ALs44e0zhISbY+EfoCLW7NHFlDTQ9f6mlJHbypMzIYtHcKUaCJstHU1whm5qeOtj+9n7W40eYAtFDUy/5N7bYtb7zIeyWxhsnKEM28Z4yJzp/M1Phcqw SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: qt.io X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2017 13:55:43.8504 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7582b795-3c47-4db8-fb64-08d542fa5eca X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 20d0b167-794d-448a-9d01-aaeccc1124ac X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0201MB1839 X-IsSubscribed: yes X-SW-Source: 2017-q4/txt/msg00112.txt.bz2 On 12/14/2017 02:43 PM, Mark Wielaard wrote: > (Meta, I have some trouble applying this with git am, it thinks the > patch is malformed. But I can apply by hand of course.) Oh, sorry for that. It's probably the leading spaces again. I keep messing up my mail setup on windows ... > The transformation seems correct. But if we can overflow/underflow > here, do we have the same problem in __libdw_offset_in_section where we > check data->d_size - offset < size, with offset a Dwarf_Off? Probably we have the same problem there. I didn't catch any instances of it, though. regards, Ulf