From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id F26563858D34 for ; Fri, 27 Aug 2021 16:59:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F26563858D34 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl [83.87.18.245]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 108683000ADC; Fri, 27 Aug 2021 18:59:02 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id B0F7F413CE32; Fri, 27 Aug 2021 18:59:01 +0200 (CEST) Message-ID: <8cae5ceb20295cbba3ab1dac8b49ac19323e8ff7.camel@klomp.org> Subject: Re: [PATCH] lib: avoid potential problems with `-fno-common` From: Mark Wielaard To: Saleem Abdulrasool , elfutils-devel@sourceware.org Date: Fri, 27 Aug 2021 18:59:01 +0200 In-Reply-To: <20210827155147.4069858-1-abdulras@google.com> References: <20210827155147.4069858-1-abdulras@google.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Aug 2021 16:59:09 -0000 Hi Saleem, On Fri, 2021-08-27 at 15:51 +0000, Saleem Abdulrasool via Elfutils-devel wr= ote: > This properly homes the fallback function into a translation unit rather > than trying to define an inline common definition for the fallback path. > The intent of the original approach was to actually simply avoid adding > a new source file that is used for the fallback path. However, that may > cause trouble with multiple definitions if the symbol does not get vague > linkage (which itself is not particularly great). This simplifies the > behaviour at the cost of an extra inode. I applied this, but messed up, sorry. I somehow dropped the lib/error.c file from the commit. When the buildbot yells and screams about a broken build that wasn't your fault. I pushed a followup commit to fix it: commit 610623458b7e98ed3e912e4b7ca8050f6ce4c698 (HEAD -> master) Author: Mark Wielaard Date: Fri Aug 27 18:47:30 2021 +0200 Add lib/error.c =20 This new file was supposed to be part of 4d6dd0e5a "lib: avoid potentia= l problems with `-fno-common`". =20 Signed-off-by: Mark Wielaard Apologies, Mark