From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 672773858281 for ; Wed, 21 Dec 2022 18:07:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 672773858281 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl [83.87.18.245]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id A16C1300071A; Wed, 21 Dec 2022 19:07:45 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 5D67D413CD0E; Wed, 21 Dec 2022 19:07:45 +0100 (CET) Message-ID: <8f8b0df0ca0d868c0d4476c424944871aa731d10.camel@klomp.org> Subject: Re: [PATCH v2 06/16] libcpu: Use __asm instead asm that can be recognized by both clang-cl and gcc From: Mark Wielaard To: Yonggang Luo , elfutils-devel@sourceware.org Date: Wed, 21 Dec 2022 19:07:45 +0100 In-Reply-To: <20221217165213.152-7-luoyonggang@gmail.com> References: <20221217165213.152-1-luoyonggang@gmail.com> <20221217165213.152-7-luoyonggang@gmail.com> Content-Type: multipart/mixed; boundary="=-iKA45K0FGhdPN2WhulCY" X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-3038.5 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-iKA45K0FGhdPN2WhulCY Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 2022-12-18 at 00:52 +0800, Yonggang Luo via Elfutils-devel wrote: > This block of code can not be removed. As it's contains a goto label > enomem that been used elsewhere aha, that certainly explains why gcc gets confused about whether those variables are used. It is slightly ugly code :{ But added a ChangeLog entry and pushed as attached. Thanks, Mark --=-iKA45K0FGhdPN2WhulCY Content-Description: Content-Disposition: inline; filename*0=0001-libcpu-Use-__asm-instead-of-asm-to-mark-variables-as.pat; filename*1=ch Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="0001-libcpu-Use-__asm-instead-of-asm-to-mark-variables-as.patch"; charset="UTF-8" RnJvbSAxOTg0ODE5ZDZlZTJkYzU2NTgzZDNmMTFiOWY2ZTNiMmY0OTFmNjJlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBZb25nZ2FuZyBMdW8gPGx1b3lvbmdnYW5nQGdtYWlsLmNvbT4K RGF0ZTogU3VuLCAxOCBEZWMgMjAyMiAwMDo1MjowMyArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIGxp YmNwdTogVXNlIF9fYXNtIGluc3RlYWQgb2YgYXNtIHRvIG1hcmsgdmFyaWFibGVzIGFzIHVzZWQK ClRoaXMgYmxvY2sgb2YgY29kZSBjYW4gbm90IGJlIHJlbW92ZWQuIEFzIGl0J3MgY29udGFpbnMg YSBnb3RvIGxhYmVsCmVub21lbSB0aGF0IGJlZW4gdXNlZCBlbHNld2hlcmUuCgpTaWduZWQtb2Zm LWJ5OiBZb25nZ2FuZyBMdW8gPGx1b3lvbmdnYW5nQGdtYWlsLmNvbT4KLS0tCiBsaWJjcHUvQ2hh bmdlTG9nICAgICB8IDQgKysrKwogbGliY3B1L2kzODZfZGlzYXNtLmMgfCA0ICsrLS0KIDIgZmls ZXMgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L2xpYmNwdS9DaGFuZ2VMb2cgYi9saWJjcHUvQ2hhbmdlTG9nCmluZGV4IGJkNTE3Yjk0Li42ZDRi NzE3YSAxMDA2NDQKLS0tIGEvbGliY3B1L0NoYW5nZUxvZworKysgYi9saWJjcHUvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsNyBAQAorMjAyMi0xMi0xOCAgWW9uZ2dhbmcgTHVvICA8bHVveW9uZ2dhbmdA Z21haWwuY29tPgorCisJKiBpMzg2X2Rpc2FzbS5jIChpMzg2X2Rpc2FzbSk6IFVzZSBfX2FzbSBp bnN0ZWFkIG9mIGFzbS4KKwogMjAyMi0xMi0yMCAgTWFyayBXaWVsYWFyZCAgPG1hcmtAa2xvbXAu b3JnPgogCiAJKiBicGZfZGlzYXNtLmM6IEluY2x1ZGUgY29tbW9uLmggYW5kIGxpYmVibFAuaC4K ZGlmZiAtLWdpdCBhL2xpYmNwdS9pMzg2X2Rpc2FzbS5jIGIvbGliY3B1L2kzODZfZGlzYXNtLmMK aW5kZXggYzQyZjhkMWMuLjA5OTQ2MjczIDEwMDY0NAotLS0gYS9saWJjcHUvaTM4Nl9kaXNhc20u YworKysgYi9saWJjcHUvaTM4Nl9kaXNhc20uYwpAQCAtNDgwLDggKzQ4MCw4IEBAIGkzODZfZGlz YXNtIChFYmwgKmVibCBfX2F0dHJpYnV0ZV9fKCh1bnVzZWQpKSwKIAogCSAgICAgIC8qIGdjYyBp cyBub3QgY2xldmVyIGVub3VnaCB0byBzZWUgdGhlIGZvbGxvd2luZyB2YXJpYWJsZXMKIAkJIGFy ZSBub3QgdXNlZCB1bmluaXRpYWxpemVkLiAgKi8KLQkgICAgICBhc20gKCIiCi0JCSAgIDogIj1t ciIgKG9wb2ZmKSwgIj1tciIgKGNvcnJlY3RfcHJlZml4KSwgIj1tciIgKGNvZGVwKSwKKwkgICAg ICBfX2FzbSAoIiIKKwkJICAgICA6ICI9bXIiIChvcG9mZiksICI9bXIiIChjb3JyZWN0X3ByZWZp eCksICI9bXIiIChjb2RlcCksCiAJCSAgICAgIj1tciIgKG5leHRfY3VyciksICI9bXIiIChsZW4p KTsKIAkgICAgfQogCi0tIAoyLjE4LjQKCg== --=-iKA45K0FGhdPN2WhulCY--