From: Mark Wielaard <mark@klomp.org>
To: "Dmitry V. Levin" <ldv@altlinux.org>, elfutils-devel@sourceware.org
Cc: Vitaly Chikunov <vt@altlinux.org>
Subject: Re: [PATCH 2/1] config: do not define DEBUGINFOD_URLS environment variable unnecessarily
Date: Mon, 09 Nov 2020 14:31:50 +0100 [thread overview]
Message-ID: <94d42371b709217847a34cdca5851a9dcf470305.camel@klomp.org> (raw)
In-Reply-To: <20201104080000.GA28269@altlinux.org>
Hi Dmitry,
On Wed, 2020-11-04 at 08:00 +0000, Dmitry V. Levin wrote:
> Before this change, when elfutils was configured without
> --enable-debuginfod-urls, the installed profile.d/debuginfod.sh and
> profile.d/debuginfod.csh scripts used to define the DEBUGINFOD_URLS
> environment variable as an non-empty string containing spaces, making
> all libdebuginfod users do extra work.
>
> Change these scripts to avoid defining the DEBUGINFOD_URLS environment
> variable unless configured using --enable-debuginfod-urls.
Looks good. Thanks for figuring out the csh variant.
Pushed.
Cheers,
Mark
next prev parent reply other threads:[~2020-11-09 13:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 8:00 [PATCH] config: Conditionalize on LIBDEBUGINFOD instead of DEBUGINFOD Dmitry V. Levin
2020-11-03 16:58 ` Mark Wielaard
2020-11-03 17:07 ` Frank Ch. Eigler
2020-11-03 17:26 ` Mark Wielaard
2020-11-03 17:32 ` Frank Ch. Eigler
2020-11-03 22:20 ` Dmitry V. Levin
2020-11-04 11:47 ` Frank Ch. Eigler
2020-11-04 8:00 ` [PATCH 2/1] config: do not define DEBUGINFOD_URLS environment variable unnecessarily Dmitry V. Levin
2020-11-09 13:31 ` Mark Wielaard [this message]
2020-11-09 13:30 ` [PATCH] config: Conditionalize on LIBDEBUGINFOD instead of DEBUGINFOD Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94d42371b709217847a34cdca5851a9dcf470305.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=ldv@altlinux.org \
--cc=vt@altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).