From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 3BBBE3858410 for ; Tue, 9 May 2023 09:57:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3BBBE3858410 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from r6.localdomain (82-217-174-174.cable.dynamic.v4.ziggo.nl [82.217.174.174]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id ED3A930008BB; Tue, 9 May 2023 11:57:43 +0200 (CEST) Received: by r6.localdomain (Postfix, from userid 1000) id 9C69734032F; Tue, 9 May 2023 11:57:42 +0200 (CEST) Message-ID: <95015daa1b23bc7a1c1938d508b1c16ebf9c6352.camel@klomp.org> Subject: Re: [PATCH 2/5] backends: Add set_initial_registers_tid callback for LoongArch From: Mark Wielaard To: Youling Tang Cc: elfutils-devel@sourceware.org, Hengqi Chen , Liwei Ge Date: Tue, 09 May 2023 11:57:42 +0200 In-Reply-To: References: <1680836368-5373-1-git-send-email-tangyouling@loongson.cn> <1680836368-5373-3-git-send-email-tangyouling@loongson.cn> <20230508195744.GE11475@gnu.wildebeest.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.1 (3.48.1-1.fc38) MIME-Version: 1.0 X-Spam-Status: No, score=-3028.7 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi=C2=A0Youling, On Tue, 2023-05-09 at 09:32 +0800, Youling Tang wrote: > Thanks for pointing out that there is no need to mask the lower 32 bits > here. >=20 > It can be modified as follows, > --- a/backends/loongarch_initreg.c > +++ b/backends/loongarch_initreg.c > @@ -79,11 +79,8 @@ loongarch_set_initial_registers_tid (pid_t tid=20 > __attribute__ ((unused)), > if (ptrace (PTRACE_GETREGSET, tid, NT_FPREGSET, &iovec) !=3D 0) > return false; >=20 > - Dwarf_Word dwarf_fregs[32]; > - for (int r =3D 0; r < 32; r++) > - dwarf_fregs[r] =3D fregs.fpr[r] & 0xFFFFFFFF; > - > - if (! setfunc (32, 32, dwarf_fregs, arg)) > + /* $f0-$f31 */ > + if (! setfunc (32, 32, &fregs.fpr[0], arg)) >=20 > Do I need to send the v2 patchset again? Please just sent this patch rebased against the current git branch. I already pushed the other 4 patches since they looked good. Thanks, Mark