From: Mark Wielaard <mark@klomp.org>
To: "Érico Nogueira" <ericonr@disroot.org>
Cc: "Érico Rolim" <erico.erc@gmail.com>, elfutils-devel@sourceware.org
Subject: Re: [PATCH v2] debuginfod.cxx: include libintl.h.
Date: Tue, 03 Nov 2020 18:13:07 +0100 [thread overview]
Message-ID: <97972c834d50f793d6f7f905d15d4ec4b28e2aed.camel@klomp.org> (raw)
In-Reply-To: <C6TA7TLKFFYR.T7DMLTZS6QWP@mussels>
On Mon, 2020-11-02 at 23:44 -0300, Érico Nogueira via Elfutils-devel
wrote:
> On Mon Nov 2, 2020 at 10:17 PM -03, Mark Wielaard wrote:
> > Thanks, added a ChangeLog entry and pushed.
>
> Sorry for missing these, and thank you for adding them. So, from what I
> understand now, the policy is to add ChangeLog entries in all affected
> directories and for every commit?
Yes, and per function/symbol. Basically following how GNU does it:
https://www.gnu.org/prep/standards/html_node/Change-Logs.html
https://www.gnu.org/software/emacs/manual/html_node/emacs/Change-Log-Commands.html
https://www.gnu.org/software/emacs/manual/html_node/emacs/Format-of-ChangeLog.html
But don't take it too seriously. I seem to be the only person left in
the project that loves ChangeLog entries. They really help me review
what was changed. If too many contributors complain we can look at
alternatives.
Cheers,
Mark
next prev parent reply other threads:[~2020-11-03 17:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 0:58 Érico Nogueira
2020-11-03 0:17 ` Mark Wielaard
2020-11-03 2:44 ` Érico Nogueira
2020-11-03 17:13 ` Mark Wielaard [this message]
2020-11-03 17:16 ` Frank Ch. Eigler
2020-11-03 17:34 ` Mark Wielaard
2020-11-05 0:36 ` Frank Ch. Eigler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97972c834d50f793d6f7f905d15d4ec4b28e2aed.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=erico.erc@gmail.com \
--cc=ericonr@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).