From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65820 invoked by alias); 21 Dec 2017 13:47:51 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 65802 invoked by uid 89); 21 Dec 2017 13:47:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=HTo:U*mark X-Spam-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: EUR01-VE1-obe.outbound.protection.outlook.com Received: from mail-ve1eur01on0096.outbound.protection.outlook.com (HELO EUR01-VE1-obe.outbound.protection.outlook.com) (104.47.1.96) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Dec 2017 13:47:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qtcompany.onmicrosoft.com; s=selector1-qt-io; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=45DAceB6MIgYsYq4tBTa4qs0w/1FABnqEu4vt/yWpvc=; b=I0q8OyjIGY0oerZ4wkqVG2s8GHIEA4v7gLv/a0ZIDMn++sxpAtKQXYp3AhPgrThMNCQ3LctfYijwWnyGWMxTG+b+6OxtGq5KjzWbhKcpusoEm2Nm/cL5ZlT2xBmVQcPxOQGyoTvCsYNoB4hAip992jyhRTuYEieZ3msWzXh2H7w= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ulf.hermann@qt.io; Received: from [10.9.78.45] (62.220.2.194) by HE1PR0201MB1835.eurprd02.prod.outlook.com (2603:10a6:3:b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.345.14; Thu, 21 Dec 2017 13:47:44 +0000 Subject: Re: [PATCH 1/2 v2] Don't overflow in __libdw_in_section To: Mark Wielaard , elfutils-devel@sourceware.org References: <5ae489eb-3981-24b4-294a-734b1c52731d@qt.io> <1513259021.15696.80.camel@klomp.org> <8b4e21a8-6328-5f05-664c-004d92461ed1@qt.io> <1513793099.3236.21.camel@klomp.org> From: Ulf Hermann Message-ID: <994f1c7b-b738-9403-b021-2a42167d468a@qt.io> Date: Thu, 21 Dec 2017 13:47:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1513793099.3236.21.camel@klomp.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [62.220.2.194] X-ClientProxiedBy: AM6PR0202CA0010.eurprd02.prod.outlook.com (2603:10a6:209:15::23) To HE1PR0201MB1835.eurprd02.prod.outlook.com (2603:10a6:3:b::13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 394e440d-3a04-480c-b4c3-08d5487969ec X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060);SRVR:HE1PR0201MB1835; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0201MB1835;3:ax6wWuO+9rrwUSPI7Ax8lzvMpFhTT4+ceMRGP8R8JfVOBJtDIjFPCk6aoqFIID130jZK5WqPEDqnMNNjQF+p0pMh8FScSIA4JTW6NvDBedXjIQFOv4p/ff7H4gd3DH4yt/7JSs2jflQmxTAG95ucwXxnbbgNJGuVpQjdSRn4BpBGAd5veRbitzzacbLS6/cgQ8TqL38CCeHJduWarzpoIzyzMFDVJKi45jOFMtr0saEi4eLUWR7lCsgP7DTab0FU;25:8kHSIklfEpgiXYf8XZ94DEJ77d+rvG61ALQeD8MVUMgen0G1oLruSiM2fHxh9gUGxv4GvAxU5z497lwXaHWi1drGqg6flXPWdp1NMyAjZ3S4zL6jZY4m+uGWsL5BsQWCPDD0IQyaoaLUTGdOlqLvZ6vEAWQKoEZzk9xfcfdvFSTVOqrpYq3KM3cQgIcuUtBu0wQ6d8Qm3RVjx9VewinyvMIkXBdISa1PX9eCNdW627UJPZ3QJiBMF/AcIib4dXKdyPMeX1T2pA2glHfvY33gA94H3chZxILqYljOeglim9V0uJPULq2L1i6vrnBmozbp6hvb0oeO17ApWHfAhMLaGQ==;31:nU8ctu7hYtHqWrYdZRI+R0buvBSv9mibDqEfMI4Jjh9rwBJP1/6pp7Yqs8Fp/gOgajZKvyiSWH08GUeENpOWqqFeF4ZYI/0gTDle1FQDbYa1HgjSKu2TEdkrtlJ3KqZCbZHoq2B9RqB8lplQ7bLCq3vaRaNG75qcvd6MGMuNmZddx6v/sB6xtJypIzzO+UF4vwRwwUis0HquVa0QkYpV7tSGMSSozEu9PnqqALkk8g0= X-MS-TrafficTypeDiagnostic: HE1PR0201MB1835: X-Microsoft-Exchange-Diagnostics: 1;HE1PR0201MB1835;20:hzqJKjZw2RV/fV4l00/Kj4o19HBPf0JKA2veW4Wrq9/iLbsWY6HlUzGN3lbbZyrNNcO6lrjsVGlJlY43+iVjLYxQ4IkT4JQq3vmhVI6om5s8bMtS5t3x+KyErzPpi+Xme4yZ3ySqxQcndU4uqssyM/mTS1TfXFipBzc081syuJckHNEDSGVAYPNdlftg/nbghtqorxcTvGKV9HwFAQ/02jbU6/i8XrXIb8ydCgkGs7Th9A0o2wWk+zIsnzcbqwov8jTDr0g5ELwYgSUE6MkE5GWGS206ehCu1Ei5eumIx3MsOo5c5aL7+c5FHPR++btKTWB3GHc5gnQrstKhNLE9suzELKm4CyAe+OJyWq9K16fO9FSlUDTx6uMwqsNMbKKPkk3ti00+FjYWpHVybjVsUEvRClkVrwvPht7G69UUvvs4yGYSpz8khVZ3dcFGKZNw+cJpewkBQXbPifQsGiQDVDnJkzr68FveY73zrRYYeP01yYUq5XlFSZroVbp8TlCL;4:oofJTavBZkdNjcYPx8UtkicvkeFWZZab6YkStsuOdZSdsm/2ppDhXxAb1P64tybm/fjSlzldCYoMtpB0s2HslWHrFT/3hiCExb3GBbj+CJO/LbThJdCfHPGgKFhQt3mDg6t0cVsScxvLFTfYMIQ416gSwX+RRDsq3yZc6FAd/9ELaQNup2r5/B+9iLmW1fcANfN96h+zqcVXm1CaBvVC/Vjey/P5mTzNv73jLyck6dGXYaWo3Y9UQ95Cf/VV3EnWZnPNeGcZFcLCnBNQPvttcg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(8121501046)(5005006)(10201501046)(3002001)(3231023)(93006095)(93001095)(6041268)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:HE1PR0201MB1835;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:HE1PR0201MB1835; X-Forefront-PRVS: 0528942FD8 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6049001)(39380400002)(39850400004)(346002)(376002)(366004)(396003)(189003)(199004)(58126008)(16576012)(50466002)(93886005)(2906002)(83506002)(64126003)(16526018)(33896004)(558084003)(36756003)(23676004)(478600001)(52146003)(2486003)(386003)(52116002)(25786009)(81166006)(3260700006)(229853002)(86362001)(5660300001)(65956001)(66066001)(77096006)(6486002)(65826007)(316002)(47776003)(2950100002)(31696002)(65806001)(6116002)(3846002)(81156014)(31686004)(230700001)(8676002)(105586002)(67846002)(68736007)(5890100001)(97736004)(53936002)(6246003)(76176011)(8936002)(7736002)(305945005)(106356001)(74482002);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR0201MB1835;H:[10.9.78.45];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: qt.io does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtIRTFQUjAyMDFNQjE4MzU7MjM6NWpxMjAybnRFbWphTHkrS3RMZkJRRm1Y?= =?utf-8?B?STF0QkVJZUp3NGVwZERBUW1RS05pbHBVTldNMjVTK1dFaGxpR3pSeExNeVZW?= =?utf-8?B?NXMvSGExU0NsSXhRbUxaaWRtZDQ4ZTNZMTRETk9HM25lMHRNZk1jVktPWmZ4?= =?utf-8?B?YkpvWmJIZFY0ZlBVY0d1Y0p0clpRVW5sa1JiZWFZRHVjMEY1elpMb2l5aFd0?= =?utf-8?B?SGdWQ0lnWm45ODdMUHZkb1BnUVlkMnMyTGRRMEtlRWZGaVd5bnZlTGJXMUFT?= =?utf-8?B?VGNPc0tESEZtYjJ3dDZ5U0pMMEJZeVlTZUw3OGptdW9neGN1eXF1Y0lGa2pR?= =?utf-8?B?TFZkZU9UbHNPdXJOamFQN0hhU1FQRHM3WkRTM0trSWVvU0tGYW5wRXhaVkhB?= =?utf-8?B?bmk5Q09xR2ZQVUR5VEtKT2tUN3E5ZkIzWit0bXFZMzJBNDZxZ3NjdWt0YkEv?= =?utf-8?B?Y3pMYVozcDFVSDJIL1dnM045UmU3aFdnU2VjMzZzaTVYQU00VDk0MXpkK0ww?= =?utf-8?B?VS9rOHEyVUtsN2V4M3YzZTl4MG92OHlqalFxY05SUGRWS2t5Zi8wT1dXenE5?= =?utf-8?B?amJ5TTJNZCtyMXorbG9IdzdnVHlKaVFLbmRSY1Z1eVZpcEhqc2tmekZVekFW?= =?utf-8?B?WHdnQU9MRURDV1Eyd3dYVTU0bDVxa0NkRmVXSU1lOWdqSy8veVI1U1BxZUdu?= =?utf-8?B?SERVV3VtbG1iTTlINWIwTmtMbm5uTml0b0VoQnZjQW1jN0dNS0VGVmtiYkIz?= =?utf-8?B?VStsbmY5TC95eTFYUUxZbEFMdkR5YS9YamNGWjAzM252bTczNE9ObXhOdkFK?= =?utf-8?B?RlZGRzBQWUU0NkVDcERFb21PNXNvSmg3VlRaRmxxMGFJQStwMzdLZFRNL3ZB?= =?utf-8?B?R1BiM3IxUnRhUmxaWG5KeVJhczJ2VjBLUU1DZVZwUk5raTg5ejloSUVpQjZx?= =?utf-8?B?TmMrUEZnWHNBNzBiMFVTOXIvV1EvRTNSYWRtaVF0ZU5xYnZGN3pXbXM5U0tM?= =?utf-8?B?eXFGRkVMQTRqMVcwdzFQY0Vld2tidzdDRDJISVY5V25Ic3lxOVlndW13V0RN?= =?utf-8?B?RUx3QlVyNGE4TDJ1c1hXbGNlbER0TXF1WWoyWTBSQm5pVkp5MjFpZ1BFY2di?= =?utf-8?B?RnY0NFJibkI1MWRDZmFDalNLY0grbUMrR3pFMk54dDBFa1g0NFNvWVgwTjJi?= =?utf-8?B?MlFsdnpzS3RmM2lVdG82djEybDgvdFpHUkFuWjhJczJPMmlOQ0Z0eVIzdVhi?= =?utf-8?B?L2hXQndldSttNDhCeHhUWUhjb0FCYmJxRjhOamF4U3UyazhJMkNEQ3hUdC9K?= =?utf-8?B?ZlRKbHNWQTNieFVNR3VtSElYQitQZFRRamJCQVdUaU8waEsyR2RrMDkwdVBE?= =?utf-8?B?WVlZVUNHRFVSdmJzRmwwVFhHWWZMcktQalZEYkV0bnE3K1VqejZSR1cyckxn?= =?utf-8?B?bkVoa09PeFFlNnpuVE9rRS9aT05xZjRLRTVEcWNjcFozZUNucXV1UmdYRG9S?= =?utf-8?B?eTI2VnM3amxuRFVPY2JobktrSmVWRllNL1RkUXN0bzUwRWZwOSsxUHNHK0hP?= =?utf-8?B?NDI3UHBtczYzcWdrY21UU2dsWnIyREJPcTBJTlBwZHNLeW5ueFg4bHplYmEx?= =?utf-8?B?WUV1UWQwakJLaCtOTHFkUG9ZdWtSVjlOUW5Ld09MRjVJa0pINkFQTkdLbkdK?= =?utf-8?B?eDVJTXp4aG5NZm9vdUxiSCtmTDQ4V1hsMm9EaVl1NlFEVVFIeExxbFF6dnlE?= =?utf-8?B?TDlqQU0xTlBYVHVlNkExcWJUNVpvMFF5TlhkeWkwcDNrK2QwVERuc05lOGQv?= =?utf-8?B?bVhWY3pTdUNmN0dLMlJGM2ZoY25Heko2Z09nN1FBM0IvQ2ltWjhZUVZlVFpJ?= =?utf-8?Q?SSLaS4Uy0/qaSd2zjW6EB2MBEiuF5RDWwo?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0201MB1835;6:vY4vyEOHDSQVUlPJcMvTujT+jeIMA2ToezGmwuq9C65xJPO4zyJbT3Dnyvuy/1KDo4XU9g/uS8JW894MI1rO1mwbgcCB3BNTsNxT0KnGE29W9Xx67KMgREF1qkZzTuFWkXqaPbJWCCO7n6Y7NQNYRCKLTmxKTzVApnKt6DjTgjuHUezuk6CsfYd3pn/dM3uzFGk/fZA2HXvFrzuMZ/L204JAqcHI/Nra4I3wdjQdHOknp6ImBvnm6mVKMRY2CPx4QuIeCyMpvohmpgcyzeQxxFfIc96kGxsDNMTQVkx8GJ5xc2jEYwhZ40C2JMioYYfanxhaydPzQWnEbYCTlhefzeO6jKutLYVgy2lz98ridtA=;5:Vq5AoRiJBh43FlS5ofFcQkcXN7LEsTTyubTuVQz1HBZPHRFQDu1ekp0E2pEr8p0oXISdAn2+s+gOyUfyoxmu+IiBxLcml2ziXtzS5+ucSaI/jmsQCvtfbmlx/oEPZudgpWyKRd6FdPvh/Ylvfx0983s2oaRRR/OOdsCz5+sN918=;24:GH+eXVWYn0dMJwgpyx5NueIYmBg7Ev+7Oh0dUjfRQeEqHSyrbaQz3fs/QKaeM9opQ/By81P5/XNz66khXuLBk7LTh/yBydVR28xbOlJUGJs=;7:+pUSRZXQNeqpKwF5LDOjcueeXqwqBGWytj40z0VPNIewf29NvZfAywqoZWRh51IZUeBk9fi/nQDgMB69wd3CeoeXr/7cd5H/am0jhNkgGLfR/DuvKJbSg7DcDmJbiXL+rBmVrZykHPfcbJOVoGNdkd6XBLC5OHLtgXgqxRfgeOBn0GA6eBEbLShqsODp9PFCqoJk7exyqewlUmvVywuAB7q8XkdL0sODrdhUM2E2K9UYB9R+YQ83kJKaSN4zHJj0 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: qt.io X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2017 13:47:44.6125 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 394e440d-3a04-480c-b4c3-08d5487969ec X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 20d0b167-794d-448a-9d01-aaeccc1124ac X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0201MB1835 X-IsSubscribed: yes X-SW-Source: 2017-q4/txt/msg00117.txt.bz2 > It is surprising we didn't see more issues with this code. There is > also the fake loc cu that fetches data from a different section. I > updated both functions as attached. Looks good to me. Ulf