From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114427 invoked by alias); 11 Jul 2019 13:36:07 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 114413 invoked by uid 89); 11 Jul 2019 13:36:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=our X-Spam-Status: No, score=-6.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Jul 2019 13:36:05 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 97EB7300059C; Thu, 11 Jul 2019 15:36:03 +0200 (CEST) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 7F37A413CC0E; Thu, 11 Jul 2019 15:36:03 +0200 (CEST) Message-ID: <9ac80d83eedfd1b4da9c5e876919982599a43e68.camel@klomp.org> Subject: Re: [[RESEND & PING]PATCH V3 0/1] Add C-SKY support From: Mark Wielaard To: Mao Han Cc: elfutils-devel@sourceware.org Date: Thu, 11 Jul 2019 13:36:00 -0000 In-Reply-To: <20190711031142.GA824@vmh-VirtualBox> References: <1539116e9ac2bfb0871481291ea0081287544e0f.camel@klomp.org> <20190711031142.GA824@vmh-VirtualBox> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-2.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2019-q3/txt/msg00044.txt.bz2 On Thu, 2019-07-11 at 11:11 +0800, Mao Han wrote: > On Wed, Jul 10, 2019 at 11:33:23PM +0200, Mark Wielaard wrote: > > On Mon, 2019-06-03 at 16:16 +0800, Mao Han wrote: > > > test binary: > > > https://github.com/c-sky/test-result/blob/master/elfutils/divzero > > > https://github.com/c-sky/test-result/blob/master/elfutils/core > >=20 > > I was looking at these, but they seem to have a wrong e_machine > > value > > of EM_RCE, not EM_CSKY? Is that deliberate? > >=20 >=20 > I used an no upstream toolchain to verify coredump backtrace, which > use > the EM_CSKY_OLD equals to 39. We have changed the EM number to 252 in > our newly released toolchain with compatibility to EM_CSKY_OLD. > See binutils/include/elf/common.h: > /* C-SKY historically used 39, the same value as MCORE, from which > the > architecture was derived. */ > #define EM_CSKY_OLD EM_MCORE Aha. But that is unfortunate on 2 levels. First EM_MCORE isn't an official e_machine name. The value 39 is associated with EM_RCE for the Morotola RCE. I assume those are the same thing? Second, it makes it hard to check the elfutils backend since you'll have to comment out all EM_RCE usage, and change the EM_CSKY to the old value. Do you have any binaries/core files generated by an upstream toolchain that uses the assigned ELF values? That would be really helpful running some tests. Thanks, Mark