public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: "Martin Liška" <mliska@suse.cz>
To: Sergei Trofimovich <slyich@gmail.com>, elfutils-devel@sourceware.org
Subject: Re: [PATCH] tests: do not fail on zero sized DIEs (binutils-2.39 compatible)
Date: Sun, 7 Aug 2022 17:32:35 +0200	[thread overview]
Message-ID: <9e0718ee-39d7-5236-419f-d0fcf903ccca@suse.cz> (raw)
In-Reply-To: <20220806085310.2603348-1-slyich@gmail.com>

On 8/6/22 10:53, Sergei Trofimovich via Elfutils-devel wrote:

Hi.

Thanks for catching this. Btw. I've also noticed the elfutils failure
in openSUSE staging project.

> binutils started producing 0-sized DIEs on functions interspersed
> by nested sections (".section ...; .previous). This led to
> run-low_high_pc.sh failure in form of:
> 
>     FAIL: run-low_high_pc.sh
>     ========================
> 
>     [b] main.c
>     [2d] main
> 
>     [b] ../sysdeps/i386/start.S
>     [26] _start
>     [40] ../sysdeps/x86/abi-note.c
>     [b52] init.c
>     [b8e] static-reloc.c
>     [2dba] _dl_relocate_static_pie
>     [2dd8] ../sysdeps/i386/crti.S
>     [2def] _init
>     lowpc: 8049000, highpc: 8049000lx
>     ../sysdeps/i386/crti.S: [2def] '_init' highpc <= lowpc
>     FAIL run-low_high_pc.sh (exit status: 255)
> 
> To work it around let's allow lowpc == highpc special case.
> 
> https://sourceware.org/bugzilla/show_bug.cgi?id=29450
> 
> Signed-off-by: Sergei Trofimovich <slyich@gmail.com>
> ---
>  tests/ChangeLog     | 4 ++++
>  tests/low_high_pc.c | 3 +++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/tests/ChangeLog b/tests/ChangeLog
> index 0c6f68ef..8296e0b6 100644
> --- a/tests/ChangeLog
> +++ b/tests/ChangeLog
> @@ -1,3 +1,7 @@
> +2022-08-04  Sergei Trofimovich  <slyich@gmail.com>
> +
> +	* low_high_pc.c (handle_die): Allow zero sized DIEs for binutils-2.39.
> +
>  2022-08-01  Mark Wielaard  <mark@klomp.org>
>  
>  	* run-debuginfod-percent-escape.sh: Add initial scan wait_ready.
> diff --git a/tests/low_high_pc.c b/tests/low_high_pc.c
> index cd022b1c..80c83b6d 100644
> --- a/tests/low_high_pc.c
> +++ b/tests/low_high_pc.c
> @@ -70,6 +70,9 @@ handle_die (Dwarf_Die *die, void *arg)
>    if (dwarf_hasattr (die, DW_AT_low_pc)
>        && dwarf_hasattr (die, DW_AT_high_pc)
>        && highpc <= lowpc
> +      /* gas-2.39 produces zero sized DIEs sometimes:
> +         https://sourceware.org/PR29451.  */
> +      && highpc != lowpc

What about rather changing 'highpc <= lowpc' to 'highpc < lowpc'
and note that ...

>        && ! (dwarf_tag (die) == DW_TAG_compile_unit && highpc == lowpc))

... here 'highpc == lowpc' would be always false and the entire condition:
'&& ! (dwarf_tag (die) == DW_TAG_compile_unit && highpc == lowpc))' always true.

Cheers,
Martin

>      {
>        printf("lowpc: %" PRIx64 ", highpc: %" PRIx64 "\n", lowpc, highpc);


  reply	other threads:[~2022-08-07 15:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-06  8:53 Sergei Trofimovich
2022-08-07 15:32 ` Martin Liška [this message]
2022-08-07 18:31 ` [PATCH v2] " Sergei Trofimovich
2022-08-07 23:17   ` Mark Wielaard
2022-10-13 14:40     ` Mark Wielaard
2022-10-13 18:13       ` Sergei Trofimovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e0718ee-39d7-5236-419f-d0fcf903ccca@suse.cz \
    --to=mliska@suse.cz \
    --cc=elfutils-devel@sourceware.org \
    --cc=slyich@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).