From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2064.outbound.protection.outlook.com [40.107.212.64]) by sourceware.org (Postfix) with ESMTPS id 615D83857340 for ; Tue, 16 May 2023 08:05:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 615D83857340 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=roku.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=roku.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mqd7n7ipLz30pb42y3U/iCuDncPGUdDbC0AQoqswVhzoonU/9FihfD1hIyKEGNc7LwBLgpKxnOq3QjnZxItWMCqgc4JR6GOulgqHbedK0TDnH3rHxV3SYkg5MPZlYrcHlumkX/aG7sdmTJQq11dhmdrae393eVCWSZWjFL8d91UY4xdvJvZrMOZ7uORGcwDsWCtlkRH/dxcynGlwoCE9XVNOAdZGk188zehz//23Fzj6XTKxRzeREypsdbMhMCPHKsskPeZ2fYQIRTNNYUrrogUwnZF1qyIHBcJWsA8JA7UJ6ICnr/yCYQ7WZMoumDWoZChbR7i8q4k95MstQJublQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j8wr7Z/Dx/SE5tfcY4+GLRcHjdYcW/nAPWwDZ1iIwFQ=; b=glEW1SXhTgYVZL0LpbKdhV0R5umSOpQXlWzQu9NVLXNgT7Rid4ysm4ZhmR3GwXw+O5KKufeIkAbBrm25j8e+aVaCTUqr4rywG7jGR2MVBne0JunnKKgJ1NrZdXiQIj2K+87fWKSJON8Ea4zhqFABo0Q6K62+/YsAJ4io6g0aB8dkXvJ01nx5T8cfWOSMq0qSI9gqiUw7ELIstHnsfs6KVLV9cZB4iNRh1JFieSXlr8iDL8F5qDXoXHtzPdY0FoOFSdHnZ3SsQU2Cv28pDxgVR0F7nyALKR4Mpho4RyBtkBQWMSICLGOCkxGdBQHt5ihNE3Uye/XLbObF8fojnvLrWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=roku.com; dmarc=pass action=none header.from=roku.com; dkim=pass header.d=roku.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=roku.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j8wr7Z/Dx/SE5tfcY4+GLRcHjdYcW/nAPWwDZ1iIwFQ=; b=E9mtunooYDHuyISLpeRl4hZUskwj+Xtbe4KowJZq07Nz/mRrmxPv29k+ps+oZMhwtcAJGUasqMAXijpZtR5clLSj6yxh9BLieB8rN/YpBpEwIE0IodgMP5gxWUhg7K2XvxzMwUwnvjmR7B30qNZ89YZzXZyi2i8ja4nS1guSdhRd6v5hOo0eF2ts6zozQzWHj2nmzPo/IGNvQBJyrEORNB9vGvvnJ7Jxqi7howysaSV+EPcexq8JsOt1M97kdJ32qgp15xqmQzgFq7VyEt9wT+izvJXY0oodmKWHx5CuWZlDogKd0tuFJ3/hqK8CqBYNY0K7yA8tO0eaEuSIGgGOvg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=roku.com; Received: from SN6PR01MB4285.prod.exchangelabs.com (2603:10b6:805:ac::33) by BL0PR0102MB3524.prod.exchangelabs.com (2603:10b6:207:1b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.33; Tue, 16 May 2023 08:05:56 +0000 Received: from SN6PR01MB4285.prod.exchangelabs.com ([fe80::6915:3762:2916:ae9e]) by SN6PR01MB4285.prod.exchangelabs.com ([fe80::6915:3762:2916:ae9e%4]) with mapi id 15.20.6387.030; Tue, 16 May 2023 08:05:56 +0000 Message-ID: <9e20452c-c739-f4c9-95cb-b48709a61af2@roku.com> Date: Tue, 16 May 2023 09:05:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [EXTERNAL] Re: [PATCH 1/5] strip: Adapt src/strip -o -f on mips Content-Language: en-US To: Mark Wielaard , ying.huang@oss.cipunited.com, elfutils-devel@sourceware.org References: <20230411081141.1762395-1-ying.huang@oss.cipunited.com> <20230411081141.1762395-2-ying.huang@oss.cipunited.com> From: Luke Diamand In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0106.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::16) To SN6PR01MB4285.prod.exchangelabs.com (2603:10b6:805:ac::33) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR01MB4285:EE_|BL0PR0102MB3524:EE_ X-MS-Office365-Filtering-Correlation-Id: fda5371d-567b-4cd1-e7de-08db55e45fe5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bWsLl64du4G7Q35V4lUndOCc5SjIUXF8J9LYMudITVQN2v83lsx5et7i6kEVLDXiBJHS43GISHMPQeMFbB95ivRhoj699gDCRAXRU++ZR+V0igbZHt/Tv+HqZoJK2Y7JpQ/SOw9oz3UDYn8FyqT+FqQHcu+fI+i3dYrSbcjTJ0pBIEhlwydrKwDqT9p6afzx7KCCSSHUQcRBngGX0nIUN9nPJwE4iuygcayrP7XVw7l30k/MHIrQskT4tB5CW8eAXPI/re7MH1Od6mcR+K/xAp7sIVscpKa9KRUb4wkLvitAHQYk8Z1kKaeJV97P7P0NWOXu/LcMCGaEPwk5tebYlG65sbHk+nQ9Nx/MXqbW5s1f1ghIaRGaXqoGJjZuPKBRbKT+UKMJkR/d00bCS0WmQ0yrrCnuzhxlCxG3kbP4tkmg80JrOzBm52tAdqJ86CwVle4o0EcYIlWuMqCAiWYV7m8geJvoENyl+hmi+9J0ZrJH+S3SiSmDK+7uT4C1Kh1jqzN3GneZ+t8vV3nGlbR8SJcOcVx+WMxOR+Ch1H45kBCnzovLkgrkt3x+iOUCaP4N2LGU3kWPqJOb+4/YBPqTTWhOgLRCk15XxtMwiR+6ejKbAiQ+I8p97kHFPd1l36BL X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR01MB4285.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39850400004)(366004)(376002)(136003)(346002)(451199021)(31686004)(6486002)(66556008)(66946007)(66476007)(478600001)(316002)(86362001)(31696002)(36756003)(83380400001)(6512007)(6506007)(2616005)(26005)(53546011)(186003)(41300700001)(8676002)(5660300002)(4744005)(2906002)(6666004)(8936002)(38100700002)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bEVRNzdnNCt3dUc0SndTTFVmU2o0UGcvMGNyQ3dOY2ZRa1Zka0tQUGNYVldU?= =?utf-8?B?VWo2cWxzYW03WHZNM3Q0VkxsV2JSSE5HUFdnNEI2NzdoaEM2UUNlcXNXWHVh?= =?utf-8?B?cjVtV1c4Y0VxanA5eXlUQVRpcW5leUYxRHd4QlFPSWRORFQ3QUNseU1Fb0JS?= =?utf-8?B?ZFI3NEtxaXRpQ2V0WDBxMlJERmg5QUlXNGRNMlZ6bmhVV1F1SUhvd0Zpelh0?= =?utf-8?B?REkvcmtjOHZHOGNhT0NDNjRQdEdXSnR1bjZmQUdMM3kzOEkzNFQ5WmFHeEZN?= =?utf-8?B?dE4wZmlLODZvWmhiVHgxRUd4UDEvMWJvZnZ4TTFaOVdFemFGamNoOXpBOGQr?= =?utf-8?B?UjZwamdwcUhnWWcremNETDZieDJFbmZPOEtLZkF4clpwQ2QwYkJmRWd0eG9y?= =?utf-8?B?UjhMeWpxR1kzMnBwN2owd2VXS0NUN2Voak9XYVlGcVh1RWEyNGs3dTc2WWJV?= =?utf-8?B?Q0YrSGtTYUF2UmNQMkdjYkFReHRiWThzZ09uNXQxVFkxSlRFd0hsUXdCR0g0?= =?utf-8?B?YWdWTGdYR0w3SzFiWURjaFA4eXU5eDdiN3BxU3lzVm5YWnR3VzN3V1J1SlJD?= =?utf-8?B?VEgvRitvcEYweFN1RkJNZFU2aHplWEpIZ1RySFlxNXlFVFNiV0UwRmhWbk1I?= =?utf-8?B?VlNhcDFpMXkzTldNTDFZRmdVdTkzY2dNSlFvVTN2dzFGVWlWMHh3TWJjbCsz?= =?utf-8?B?RXRaektOaU5oUDl2NFdMaDJ0NkdjZ3BNcWlJV2k0K3BsNDdwVVNmRVZKSjBL?= =?utf-8?B?R3hOY1ZQcUVQWXBrdW1vZUJxZ2RBOGY0K3FPbXFMOG4yNEhwaHhSSWdRVm4x?= =?utf-8?B?MTg4OTJrRGJzYmF3U084b2tKVkJMTUtURUlud0RsblJDT1hTOUlRT0Nwc1dI?= =?utf-8?B?bHF1WSt6Y0hSVjdpTEZZS3hwM0k1SWFLYmNJb2RON2VocHN0dktpSjNEelQ4?= =?utf-8?B?Nmh6czQxV1ZZWERnbmYwdVU2eHpsWFhhVmJycE5MRGxyNlRZNG5qNWF1eGhT?= =?utf-8?B?OFpxeWdHRXlLMERMOU41YTE3VDEvdlFRN0NyY2FGMGpXNUxMSUZybnVYcTFD?= =?utf-8?B?WFlWYmJTTkY0N1M5anJjUi9tVmthdHdZdXV3eFdQV3BrdFQ0bG10M0g2VkUw?= =?utf-8?B?dFV0ZkFieEM5RU95TDgzcVhsbjB2VkE1SHllTUZIbW9lbjdJRmtXYzlEZXg4?= =?utf-8?B?dERyeXVJcVFEVWNYOGFqY0xvZjNLNVhRTzlvcUtOVHJKN2gya0pldFBmaGkx?= =?utf-8?B?MVNMYTFFSXBQNEpiMEg2QkgraDdIY05lS3ZySFNtM2U5aXZwYm50bGFZWkEw?= =?utf-8?B?K2h6T1JpLzNmZi85bDBJVkxTNWZQcWNidU9SZzhHWXVLMG5ad0VYWG5yOVNu?= =?utf-8?B?ZktaNGpNSGpwbzlCK2k2bXRpUDFwVjg4Zzh2RXBoMGZLaU9sOUMwTjFZTExE?= =?utf-8?B?d0pGUWJYbTFpdERnMER6OWJydms5d0x3SDNDdG9ndHJBUndqNzQyNjkrUXQ4?= =?utf-8?B?Sm4vQ00yVU4zaFd6c3FFbHFoUnlKcnF5UUJQb0hnS3VrKzd6N1MzNlZoc0xa?= =?utf-8?B?RHZlRXpZWWJZdUR5MjcyWlB0NHFzclVxREJ5cmNxTE9YQ3RNNndKMkxtd0M3?= =?utf-8?B?NDUzOSt0WExyQjhodVF6Tm5wNk9JU3lXQTEyNWRacXMyLzF5ZUZZcWN0RUox?= =?utf-8?B?dTYrTDVWa0Y1aDBxZFFKQWpWNGhySE5PLzNHWlBOejBOL0g0cEtKZUVwcDNu?= =?utf-8?B?S0swNU51UUptTjVVdmJJSVQ5ZXBZbVhZV0IzYXlmc0F1NnJtWnRrU2g4c1FS?= =?utf-8?B?aXVTWUFwZXk1WWR2ZHpHb20vOVB0V0VGNjN6SGVHajd2TEhDeHlFVUh0bzNB?= =?utf-8?B?S1Z6OWRjM1ljTU1MMzAwRDdzanlYdE9jSDJDd1BmU0FNcVVKN0UzMWRXbC82?= =?utf-8?B?RXA1ajU0NlovTGNGcWloZTdtODNjSTVpaklqR1lTcnhkSDduUGluOXV5MU81?= =?utf-8?B?Nm1VdUx6NExHTnpiUkd4dU1STjE3SmxpOHN0VXNIc1RrTkxhY0hIZ3JGRXph?= =?utf-8?B?aWNDNWorb1FsRWc2MVVJd0xIMTg0SmJ4TVhZNlA5b1h2M09ldHNIelFlOGNI?= =?utf-8?Q?5M7nXDepSOFfrFMKJWemznsy1?= X-OriginatorOrg: roku.com X-MS-Exchange-CrossTenant-Network-Message-Id: fda5371d-567b-4cd1-e7de-08db55e45fe5 X-MS-Exchange-CrossTenant-AuthSource: SN6PR01MB4285.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2023 08:05:55.6683 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 00fc7e42-ad65-4c4c-ab54-848ba124a5b7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: thmnjPVt73nBTkRBpY/UvU++Zafqwu56j4ob9yENrDs8xnyAYzqWIMV7QhwDaWhADNsGVNT64ZOLyEaTIord8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR0102MB3524 X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 09/05/2023 16:15, Mark Wielaard wrote: > Hi, > > On Tue, 2023-04-11 at 16:12 +0800, Ying Huang wrote: >> From: Ying Huang >> >> In mips64 little-endian, r_info consists of four byte fields(contains >> three reloc types) and a 32-bit symbol index. In order to adapt >> GELF_R_SYM and GELF_R_TYPE, need convert raw data to get correct symbol >> index and type. > > Is there a spec that describes this? > > I see you adjusted elf.h to include: > > +#define ELF64_MIPS_R_TYPE(i) ((i) & 0xff) > +#define ELF64_MIPS_R_TYPE2(i) (((i) >> 8) & 0xff) > +#define ELF64_MIPS_R_TYPE3(i) (((i) >> 16) & 0xff) > Is this patch intended to support 32 bit MIPS (and MIPSEL) ? For me it did not work but I could see if I can add that in. (From a very long time ago, I have some patches based on the debian MIPS support but I never managed to find time to upstream them, so this is great to finally see!) Luke