From: "Érico Nogueira" <ericonr@disroot.org>
To: <elfutils-devel@sourceware.org>
Subject: [PATCH] Don't use locale functions when libintl header isn't included.
Date: Mon, 26 Oct 2020 01:11:04 -0300 [thread overview]
Message-ID: <C6MJ1VN4HC87.TY7U7NY4GEZ3@mussels> (raw)
debuginfod.cxx used the bindtextdomain() and textdomain() functions
despite not including any translated output. These functions were also
used without including the libintl.h header.
Signed-off-by: Érico Rolim <erico.erc@gmail.com>
---
debuginfod/debuginfod.cxx | 2 --
1 file changed, 2 deletions(-)
diff --git a/debuginfod/debuginfod.cxx b/debuginfod/debuginfod.cxx
index 2b68ff1f..bb95aefb 100644
--- a/debuginfod/debuginfod.cxx
+++ b/debuginfod/debuginfod.cxx
@@ -3092,8 +3092,6 @@ int
main (int argc, char *argv[])
{
(void) setlocale (LC_ALL, "");
- (void) bindtextdomain (PACKAGE_TARNAME, LOCALEDIR);
- (void) textdomain (PACKAGE_TARNAME);
/* Tell the library which version we are expecting. */
elf_version (EV_CURRENT);
--
2.29.0
next reply other threads:[~2020-10-26 4:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 4:11 Érico Nogueira [this message]
2020-10-26 18:46 ` Mark Wielaard
2020-10-26 18:53 ` Érico Nogueira
2020-10-26 22:22 ` Mark Wielaard
2020-10-26 22:22 ` Frank Ch. Eigler
2020-10-26 22:44 ` Érico Nogueira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C6MJ1VN4HC87.TY7U7NY4GEZ3@mussels \
--to=ericonr@disroot.org \
--cc=elfutils-devel@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).