Re: [PATCH] Don't use locale functions when libintl header isn't included.

["Érico Nogueira" <ericonr@disroot.org>]

On Mon Oct 26, 2020 at 4:46 PM -03, Mark Wielaard wrote:
> Hi Érico,
>
> On Mon, 2020-10-26 at 01:11 -0300, Érico Nogueira via Elfutils-devel
> wrote:
> > debuginfod.cxx used the bindtextdomain() and textdomain() functions
> > despite not including any translated output. These functions were also
> > used without including the libintl.h header.
>
> debuginfod doesn't directly use any translated output, but it links
> against libeu.a which provides the print_version function, which does
> use translated output. So maybe the correct fix is to #include
> <libintl.h> instead?
>
> Cheers,
>
> Mark

Hi Mark,

I had talked with fche on #elfutils, and it was suggested that I could
remove the locale functions from debuginfod.cxx. If you think it makes
more sense to simply include the header (which is what I did initially
for my own build), I guess I should remove the comment about C++ support
as well, right? Or modify it to something else, at least. Would you have
any suggestions for that?

Thanks,
Érico