From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from knopi.disroot.org (knopi.disroot.org [178.21.23.139]) by sourceware.org (Postfix) with ESMTPS id E1CB23860017 for ; Mon, 26 Oct 2020 18:59:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E1CB23860017 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 14113536E9; Mon, 26 Oct 2020 19:59:18 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pVDqIIDZ68Vg; Mon, 26 Oct 2020 19:59:17 +0100 (CET) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH] Don't use locale functions when libintl header isn't included. From: =?utf-8?q?=C3=89rico_Nogueira?= To: "Mark Wielaard" , Date: Mon, 26 Oct 2020 15:53:49 -0300 Message-Id: In-Reply-To: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Oct 2020 18:59:22 -0000 On Mon Oct 26, 2020 at 4:46 PM -03, Mark Wielaard wrote: > Hi =C3=89rico, > > On Mon, 2020-10-26 at 01:11 -0300, =C3=89rico Nogueira via Elfutils-devel > wrote: > > debuginfod.cxx used the bindtextdomain() and textdomain() functions > > despite not including any translated output. These functions were also > > used without including the libintl.h header. > > debuginfod doesn't directly use any translated output, but it links > against libeu.a which provides the print_version function, which does > use translated output. So maybe the correct fix is to #include > instead? > > Cheers, > > Mark Hi Mark, I had talked with fche on #elfutils, and it was suggested that I could remove the locale functions from debuginfod.cxx. If you think it makes more sense to simply include the header (which is what I did initially for my own build), I guess I should remove the comment about C++ support as well, right? Or modify it to something else, at least. Would you have any suggestions for that? Thanks, =C3=89rico