Re: [PATCH] Don't use __BEGIN_DECLS macros from glibc.

["Érico Nogueira" <ericonr@disroot.org>]

On Mon Oct 26, 2020 at 8:58 PM -03, Dmitry V. Levin wrote:
> On Mon, Oct 26, 2020 at 05:44:24PM -0300, Érico Nogueira via
> Elfutils-devel wrote:
> > From: Érico Rolim <erico.erc@gmail.com>
> > 
> > These macros are mostly internal to glibc and require the inclusion of
> > <sys/cdefs.h> (here included indirectly via <features.h>), which isn't a
> > standard header.
> > 
> > Since they are only required once, replacing them with their definition
> > is simple.
> > 
> > Signed-off-by: Érico Rolim <erico.erc@gmail.com>
> > ---
> >  libelf/elf.h | 10 ++++++----
> >  1 file changed, 6 insertions(+), 4 deletions(-)
>
> This file is a verbatim copy of glibc's elf/elf.h, see
> git log -- libelf/elf.h
>
>
> --
> ldv

Hm, I see. This change would only make it necessary to restore the top
and bottom of the file after any update; do you think that would be too
much trouble? I could also add a comment to make it clear why the
explicit `extern "C"` is necessary.

Thanks,
Érico