From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ericonr@disroot.org>
Received: from knopi.disroot.org (knopi.disroot.org [178.21.23.139])
 by sourceware.org (Postfix) with ESMTPS id E5CA93857C43
 for <elfutils-devel@sourceware.org>; Mon, 26 Oct 2020 21:36:35 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E5CA93857C43
Received: from localhost (localhost [127.0.0.1])
 by disroot.org (Postfix) with ESMTP id C964551B01;
 Mon, 26 Oct 2020 22:36:34 +0100 (CET)
X-Virus-Scanned: Debian amavisd-new at disroot.org
Received: from knopi.disroot.org ([127.0.0.1])
 by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id aqvdjq43CL6D; Mon, 26 Oct 2020 22:36:33 +0100 (CET)
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
To: "Dmitry V. Levin" <ldv@altlinux.org>
Cc: <elfutils-devel@sourceware.org>, =?utf-8?q?=C3=89rico_Rolim?=
 <erico.erc@gmail.com>
Subject: Re: [PATCH] Don't use __BEGIN_DECLS macros from glibc.
From: =?utf-8?q?=C3=89rico_Nogueira?= <ericonr@disroot.org>
Date: Mon, 26 Oct 2020 18:34:59 -0300
Message-Id: <C6N595R9UAS1.1YDLF1DJRB651@mussels>
In-Reply-To: <20201026205810.GA3247@altlinux.org>
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,
 SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: elfutils-devel@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Elfutils-devel mailing list <elfutils-devel.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/elfutils-devel>,
 <mailto:elfutils-devel-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/elfutils-devel/>
List-Help: <mailto:elfutils-devel-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/elfutils-devel>,
 <mailto:elfutils-devel-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Oct 2020 21:36:37 -0000

On Mon Oct 26, 2020 at 8:58 PM -03, Dmitry V. Levin wrote:
> On Mon, Oct 26, 2020 at 05:44:24PM -0300, =C3=89rico Nogueira via
> Elfutils-devel wrote:
> > From: =C3=89rico Rolim <erico.erc@gmail.com>
> >=20
> > These macros are mostly internal to glibc and require the inclusion of
> > <sys/cdefs.h> (here included indirectly via <features.h>), which isn't =
a
> > standard header.
> >=20
> > Since they are only required once, replacing them with their definition
> > is simple.
> >=20
> > Signed-off-by: =C3=89rico Rolim <erico.erc@gmail.com>
> > ---
> >  libelf/elf.h | 10 ++++++----
> >  1 file changed, 6 insertions(+), 4 deletions(-)
>
> This file is a verbatim copy of glibc's elf/elf.h, see
> git log -- libelf/elf.h
>
>
> --
> ldv

Hm, I see. This change would only make it necessary to restore the top
and bottom of the file after any update; do you think that would be too
much trouble? I could also add a comment to make it clear why the
explicit `extern "C"` is necessary.

Thanks,
=C3=89rico